Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: remove use of "random port" regarding dgram send #19620
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@tlhunter Can you check your local and GitHub settings: It seems the commit has not proper attribution. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@vsemozhetbyt I would wait for confirmation from the author – the commit does have proper attribution as far as I can tell (name + email present and the email seems valid). That usually means that it’s easier for the author to add that email to github, if they do want that. |
This comment has been minimized.
This comment has been minimized.
|
@vsemozhetbyt @addaleax Whoops! That email should now be properly associated to my GH account. |
vsemozhetbyt
added a commit
that referenced
this pull request
Mar 27, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed in cdfe47b Thank you! |
targos
added a commit
that referenced
this pull request
Mar 27, 2018
BethGriggs
added a commit
that referenced
this pull request
Dec 4, 2018
PR-URL: #19620 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tlhunter commentedMar 26, 2018
Checklist
I removed the use of "random port" when referring to sending messages with dgram. Specifically in the examples the port isn't random, it is a hand-picked port which stays the same. Referring to it as a random port is confusing because in the listening methods the phrase "random port" has a special meaning, i.e. providing no port and letting the OS pick a random port.