test: update link according to NIST bibliography #19593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to NIST SP 800 38D, this is the document the link orginally pointed to. Fixes: nodejs#17619
cjihrig
approved these changes
Mar 25, 2018
|
@starkwang There is no "official" link anymore, NIST does not seem to provide the document anymore. IMO it is sufficient to provide the name of the document and the authors. |
trivikr
approved these changes
Mar 25, 2018
richardlau
reviewed
Mar 25, 2018
| // http://csrc.nist.gov/groups/ST/toolkit/BCM/documents/ | ||
| // proposedmodes/gcm/gcm-revised-spec.pdf | ||
| // Following test cases are from "The Galois/Counter Mode of Operation (GCM)" | ||
| // by D. McGrew and J. Viega, published by the Natl. Inst. Stand. Technol. |
There was a problem hiding this comment.
National Institute of Standards and Technology?
There was a problem hiding this comment.
Yeah... Natl. Inst. Stand. Technol. is the abbreviation which is used in their own document, I just copied it. Personally, I would just write NIST, what do you prefer?
There was a problem hiding this comment.
I think NIST would be better.
lpinca
approved these changes
Mar 25, 2018
trivikr
approved these changes
Mar 27, 2018
richardlau
approved these changes
Mar 27, 2018
thefourtheye
approved these changes
Mar 27, 2018
|
Landed in ed0501f |
trivikr
pushed a commit
that referenced
this issue
Mar 27, 2018
According to NIST SP 800 38D, this is the document the link orginally pointed to. Fixes: #17619 PR-URL: #19593 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos
pushed a commit
that referenced
this issue
Apr 2, 2018
According to NIST SP 800 38D, this is the document the link orginally pointed to. Fixes: #17619 PR-URL: #19593 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this issue
Dec 4, 2018
According to NIST SP 800 38D, this is the document the link orginally pointed to. Fixes: #17619 PR-URL: #19593 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
According to Appendix E of NIST SP 800 38D, this is the document the link orginally pointed to.
Fixes: #17619
Checklist