★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/18792Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make tls test more rigorous #18792

Closed
wants to merge 1 commit into from
Closed

test: make tls test more rigorous #18792

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Feb 15, 2018

  • exit naturally, don't use process.exit()
  • ensure callbacks are actually called

@bnoordhuis
test: make tls test more rigorous
a3f0ea5 
* exit naturally, don't use process.exit()
* ensure callbacks are actually called
@jasnell
Copy link
Member

@jasnell jasnell commented Feb 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13211/

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Feb 16, 2018

Landed in 3c29adb 🎉

@BridgeAR BridgeAR closed this Feb 16, 2018
BridgeAR added a commit to BridgeAR/node that referenced this issue Feb 16, 2018
@bnoordhuis @BridgeAR
test: make tls test more rigorous
3c29adb 
* exit naturally, don't use process.exit()
* ensure callbacks are actually called

PR-URL: nodejs#18792
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins added a commit that referenced this issue Feb 21, 2018
@bnoordhuis @MylesBorins
test: make tls test more rigorous
80e1cb7 
* exit naturally, don't use process.exit()
* ensure callbacks are actually called

PR-URL: #18792
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins added a commit that referenced this issue Feb 21, 2018
@bnoordhuis @MylesBorins
test: make tls test more rigorous
849f5c3 
* exit naturally, don't use process.exit()
* ensure callbacks are actually called

PR-URL: #18792
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MayaLekova added a commit to MayaLekova/node that referenced this issue May 8, 2018
@bnoordhuis @MayaLekova
test: make tls test more rigorous
35a9b72 
* exit naturally, don't use process.exit()
* ensure callbacks are actually called

PR-URL: nodejs#18792
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins added a commit that referenced this issue Aug 7, 2018
@bnoordhuis @MylesBorins
test: make tls test more rigorous
077fb0a 
* exit naturally, don't use process.exit()
* ensure callbacks are actually called

PR-URL: #18792
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins added a commit that referenced this issue Aug 7, 2018
@bnoordhuis @MylesBorins
test: make tls test more rigorous
d46ae57 
* exit naturally, don't use process.exit()
* ensure callbacks are actually called

PR-URL: #18792
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins added a commit that referenced this issue Aug 9, 2018
@bnoordhuis @MylesBorins
test: make tls test more rigorous
aeb0f96 
* exit naturally, don't use process.exit()
* ensure callbacks are actually called

PR-URL: #18792
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins added a commit that referenced this issue Aug 16, 2018
@bnoordhuis @MylesBorins
test: make tls test more rigorous
f534bd8 
* exit naturally, don't use process.exit()
* ensure callbacks are actually called

PR-URL: #18792
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@evanlucas evanlucas

@addaleax addaleax

@benjamingr benjamingr

@cjihrig cjihrig

@tniessen tniessen

@mmarchini mmarchini

@richardlau richardlau

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready fast-track test
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet