★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/18681Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add error check to fs example #18681

Closed
wants to merge 1 commit into from
Closed

doc: add error check to fs example #18681

wants to merge 1 commit into from

Conversation

evanlucas
Copy link
Member

@evanlucas evanlucas commented Feb 9, 2018

Previously, the err passed to the callback of fs.open() was not checked.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@evanlucas
doc: add error check to fs example
010065a 
Previously, the err passed to the callback of fs.open() was not checked.
cjihrig
cjihrig approved these changes Feb 9, 2018
View changes
@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Feb 9, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/165/

lpinca
lpinca approved these changes Feb 9, 2018
View changes
jasnell
jasnell approved these changes Feb 9, 2018
View changes
@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Feb 10, 2018

Landed in 540cbf8 🎉

@BridgeAR BridgeAR closed this Feb 10, 2018
BridgeAR added a commit to BridgeAR/node that referenced this issue Feb 10, 2018
@evanlucas @BridgeAR
doc: add error check to fs example
540cbf8 
Previously, the err passed to the callback of fs.open() was not checked.

PR-URL: nodejs#18681
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@evanlucas evanlucas deleted the fsexistsdocs branch Feb 14, 2018
MylesBorins added a commit that referenced this issue Feb 21, 2018
@evanlucas @MylesBorins
doc: add error check to fs example
38451b9 
Previously, the err passed to the callback of fs.open() was not checked.

PR-URL: #18681
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins added a commit that referenced this issue Feb 21, 2018
@evanlucas @MylesBorins
doc: add error check to fs example
c875d17 
Previously, the err passed to the callback of fs.open() was not checked.

PR-URL: #18681
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins added a commit that referenced this issue Feb 21, 2018
@evanlucas @MylesBorins
doc: add error check to fs example
edcddeb 
Previously, the err passed to the callback of fs.open() was not checked.

PR-URL: #18681
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins added a commit that referenced this issue Feb 21, 2018
@evanlucas @MylesBorins
doc: add error check to fs example
3cfb313 
Previously, the err passed to the callback of fs.open() was not checked.

PR-URL: #18681
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MayaLekova added a commit to MayaLekova/node that referenced this issue May 8, 2018
@evanlucas @MayaLekova
doc: add error check to fs example
a17d580 
Previously, the err passed to the callback of fs.open() was not checked.

PR-URL: nodejs#18681
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins added a commit that referenced this issue Aug 7, 2018
@evanlucas @MylesBorins
doc: add error check to fs example
d388282 
Previously, the err passed to the callback of fs.open() was not checked.

PR-URL: #18681
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins added a commit that referenced this issue Aug 7, 2018
@evanlucas @MylesBorins
doc: add error check to fs example
98b0ec3 
Previously, the err passed to the callback of fs.open() was not checked.

PR-URL: #18681
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins added a commit that referenced this issue Aug 9, 2018
@evanlucas @MylesBorins
doc: add error check to fs example
79763e6 
Previously, the err passed to the callback of fs.open() was not checked.

PR-URL: #18681
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins added a commit that referenced this issue Aug 16, 2018
@evanlucas @MylesBorins
doc: add error check to fs example
a26454e 
Previously, the err passed to the callback of fs.open() was not checked.

PR-URL: #18681
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski

@jasnell jasnell

@lpinca lpinca

@cjihrig cjihrig

@tniessen tniessen

@BridgeAR BridgeAR

@vsemozhetbyt vsemozhetbyt

Assignees
No one assigned
Labels
author ready doc fast-track fs
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
10 participants
@evanlucas @vsemozhetbyt @BridgeAR @apapirovski @jasnell @lpinca @cjihrig @tniessen @MylesBorins @nodejs-github-bot