★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/18492Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix unassigned deprecation codes #18492

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@thefourtheye thefourtheye

@cjihrig cjihrig

@tniessen tniessen

@BridgeAR BridgeAR

@vsemozhetbyt vsemozhetbyt

Assignees
No one assigned
Labels
crypto dont-land-on-v6.x dont-land-on-v8.x fast-track
Projects
None yet
Milestone
No milestone
9 participants
@jasnell @thefourtheye @cjihrig @tniessen @BridgeAR @vsemozhetbyt @MylesBorins @addaleax @nodejs-github-bot
@jasnell
Copy link
Member

jasnell commented Feb 1, 2018

Oopsie... Forgot to assign the deprecation code when landing #18333

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto, docs

@jasnell jasnell added the fast-track label Feb 1, 2018

@nodejs-github-bot nodejs-github-bot added the crypto label Feb 1, 2018

@vsemozhetbyt

vsemozhetbyt approved these changes Feb 1, 2018
View changes

@thefourtheye

thefourtheye approved these changes Feb 1, 2018
View changes

@thefourtheye

This comment has been minimized.

Sign in to view
Copy link
Contributor

thefourtheye commented Feb 1, 2018

Just making an observation. We have DEP0089 after DEP0086.
@tniessen

tniessen approved these changes Feb 1, 2018
View changes

@BridgeAR

BridgeAR approved these changes Feb 1, 2018
View changes

@BridgeAR BridgeAR added the author ready label Feb 1, 2018

@cjihrig

cjihrig approved these changes Feb 1, 2018
View changes

@jasnell

This comment has been minimized.

Sign in to view
Copy link
Member Author

jasnell commented Feb 1, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12888/

@jasnell jasnell changed the title crypto: fix unassignd deprecation code doc: fix unassigned deprecation codes Feb 1, 2018

@jasnell jasnell force-pushed the jasnell:fix-dep-code branch from 90ae818 to 54562c0 Feb 1, 2018

@jasnell jasnell referenced this pull request Feb 1, 2018

Closed

crypto: docs-only deprecate crypto.fips, replace #18335

4 of 4 tasks complete

jasnell added a commit that referenced this pull request Feb 1, 2018

@jasnell
crypto,doc: fix unassignd deprecation codes 
Missed when landing the original PRs

PR-URL: #18492
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2ac6658
@jasnell

This comment has been minimized.

Sign in to view
Copy link
Member Author

jasnell commented Feb 1, 2018

Landed in 2ac6658

@jasnell jasnell closed this Feb 1, 2018

kcaulfield94 added a commit to kcaulfield94/node that referenced this pull request Feb 2, 2018

@jasnell @kcaulfield94
crypto,doc: fix unassignd deprecation codes 
Missed when landing the original PRs

PR-URL: nodejs#18492
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
922fb83

@addaleax addaleax removed the author ready label Feb 4, 2018

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

@jasnell @msoechting
crypto,doc: fix unassignd deprecation codes 
Missed when landing the original PRs

PR-URL: nodejs#18492
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
6ba0cf2

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

@jasnell @msoechting
crypto,doc: fix unassignd deprecation codes 
Missed when landing the original PRs

PR-URL: nodejs#18492
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
17fe9c9

@MylesBorins MylesBorins added dont-land-on-v6.x dont-land-on-v8.x dont-land-on-v9.x labels Feb 20, 2018

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

@jasnell @MayaLekova
crypto,doc: fix unassignd deprecation codes 
Missed when landing the original PRs

PR-URL: nodejs#18492
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ced104e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.