/node

add vdeturckheim as collaborator #18432

Closed
wants to merge 1 commit into
from
+2 −0

Conversation

Reviewers

@apapirovski apapirovski

@addaleax addaleax

@TimothyGu TimothyGu

@cjihrig cjihrig

@devsnek devsnek

@vsemozhetbyt vsemozhetbyt

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
7 participants
@vdeturckheim @devsnek @apapirovski @TimothyGu @addaleax @cjihrig @vsemozhetbyt
@vdeturckheim
Member

vdeturckheim commented Jan 29, 2018 •
Edited 1 time

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@vdeturckheim vdeturckheim added the doc label Jan 29, 2018

@apapirovski

apapirovski approved these changes Jan 29, 2018
View changes

🎉

README.md
@@ -496,6 +496,8 @@ For more information about the governance of the Node.js project, see
* [Trott](https://github.com/Trott) -
**Rich Trott** <rtrott@gmail.com> (he/him)
* [tunniclm](https://github.com/tunniclm) -
+**Vladimir de Turckheim** <vlad2t@hotmail.com> (he/him)
+* [vdeturckheim](https://github.com/vdeturckheim/) -
@apapirovski

apapirovski Jan 29, 2018

Member

Can we remove the trailing slash for consistency?

@devsnek
Contributor

devsnek commented Jan 29, 2018

something here doesn't look quite right?

@apapirovski
Member

apapirovski commented Jan 29, 2018

something here doesn't look quite right?

Ah, the order of these strikes again... 😆I feel like this happens every other collaborator PR.
@TimothyGu
Member

TimothyGu commented Jan 29, 2018

cluster: add cwd to cluster.settings

🤔
@vdeturckheim
Member

vdeturckheim commented Jan 29, 2018

landed in 4a49833

@vdeturckheim vdeturckheim closed this Jan 29, 2018

@vdeturckheim vdeturckheim deleted the vdeturckheim:add_vdeturckheim_as_colaborator branch Jan 29, 2018

vdeturckheim added a commit that referenced this pull request Jan 29, 2018

@vdeturckheim
doc: add vdeturckheim as collaborator 
PR-URL: #18432
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
4a49833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment