process: small improvements to internals #18330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Jan 24, 2018
joyeecheung
approved these changes
Jan 25, 2018
maclover7
approved these changes
Jan 26, 2018
|
Landing... |
maclover7
pushed a commit
to maclover7/node
that referenced
this issue
Jan 26, 2018
PR-URL: nodejs#18330 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
maclover7
pushed a commit
to maclover7/node
that referenced
this issue
Jan 26, 2018
PR-URL: nodejs#18330 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
evanlucas
pushed a commit
that referenced
this issue
Jan 30, 2018
PR-URL: #18330 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
evanlucas
pushed a commit
that referenced
this issue
Jan 30, 2018
PR-URL: #18330 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
|
this might need a bit of time for lts |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this issue
May 8, 2018
PR-URL: nodejs#18330 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this issue
May 8, 2018
PR-URL: nodejs#18330 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some small tweaks:
Remove unnecessary call to a binding which is already guaranteed to be loaded via requiring
child_process(and that's even if calling that binding was necessary in the first place)Cleanup
setupSignalHandlers, including removing an outdated comment, using null prototype Object, not calling C++ repeatedly to get the binding, etc.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
process