★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/18272Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make linters independent of local node #18272

Closed
wants to merge 2 commits into from
Closed

build: make linters independent of local node #18272

wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jan 20, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@joyeecheung
Copy link
Member Author

@joyeecheung joyeecheung commented Jan 20, 2018 •
edited

cc @nodejs/build

CI: https://ci.nodejs.org/job/node-test-pull-request/12644/

New one: https://ci.nodejs.org/job/node-test-pull-request/12665/

@joyeecheung
Copy link
Member Author

@joyeecheung joyeecheung commented Jan 23, 2018

Landed in 6a56a0a...13bc53f, thanks!

joyeecheung added a commit that referenced this issue Jan 23, 2018
@joyeecheung
build: make lint-md independent of local node
be0778b 
PR-URL: #18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this issue Jan 23, 2018
@joyeecheung
build: make lint-js independent of local node
13bc53f 
PR-URL: #18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas added a commit that referenced this issue Jan 30, 2018
@joyeecheung @evanlucas
build: make lint-md independent of local node
ce1eb0b 
PR-URL: #18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas added a commit that referenced this issue Jan 30, 2018
@joyeecheung @evanlucas
build: make lint-js independent of local node
2a9afc4 
PR-URL: #18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Feb 27, 2018

Should this be backported to v6.x-staging or v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

joyeecheung added a commit to joyeecheung/node that referenced this issue Mar 6, 2018
@joyeecheung
build: make lint-md independent of local node
126aefb 
PR-URL: nodejs#18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit to joyeecheung/node that referenced this issue Mar 6, 2018
@joyeecheung
build: make lint-js independent of local node
4526a07 
PR-URL: nodejs#18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung joyeecheung mentioned this pull request Mar 30, 2018
Closed
3 tasks
BethGriggs pushed a commit that referenced this issue Apr 10, 2018
@joyeecheung @BethGriggs
build: make lint-md independent of local node
d537f45 
PR-URL: #18272
Backport-PR-URL: #19190
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this issue Apr 10, 2018
@joyeecheung @BethGriggs
build: make lint-js independent of local node
333d7dd 
PR-URL: #18272
Backport-PR-URL: #19190
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova added a commit to MayaLekova/node that referenced this issue May 8, 2018
@joyeecheung @MayaLekova
build: make lint-md independent of local node
4bed892 
PR-URL: nodejs#18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova added a commit to MayaLekova/node that referenced this issue May 8, 2018
@joyeecheung @MayaLekova
build: make lint-js independent of local node
809af5f 
PR-URL: nodejs#18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@gibfahn gibfahn

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
5 participants
@joyeecheung @MylesBorins @jasnell @gibfahn @nodejs-github-bot