★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/18205Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #18205

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@apapirovski apapirovski

@jasnell jasnell

@evanlucas evanlucas

@addaleax addaleax

@cjihrig cjihrig

@richardlau richardlau

@BridgeAR BridgeAR

@mhdawson mhdawson

Assignees
No one assigned
Labels
C++ author ready dont-land-on-v6.x dont-land-on-v8.x fast-track fs intl
Projects
None yet
Milestone
No milestone
@bnoordhuis
Copy link
Member

bnoordhuis commented Jan 17, 2018

No description provided.

@nodejs-github-bot nodejs-github-bot added C++ fs intl labels Jan 17, 2018

@apapirovski

apapirovski approved these changes Jan 17, 2018
View changes

@evanlucas

evanlucas approved these changes Jan 17, 2018
View changes

@cjihrig

cjihrig approved these changes Jan 17, 2018
View changes

@richardlau

richardlau approved these changes Jan 17, 2018
View changes

Copy link
Member

richardlau left a comment

The src/node_file.cc changes are the same as #18200.
@jasnell

jasnell reviewed Jan 17, 2018
View changes

src/node_i18n.cc
@@ -788,7 +788,8 @@ static int GetColumnWidth(UChar32 codepoint,
if (ambiguous_as_full_width) {
return 2;
}
// Fall through if ambiguous_as_full_width if false.
// If ambiguous_as_full_width is false:
// Fall through

This comment has been minimized.

Sign in to view
Copy link
@jasnell

jasnell Jan 17, 2018

Member

Unrelated change?

This comment has been minimized.

Sign in to view
Copy link
@bnoordhuis

bnoordhuis Jan 17, 2018

Author Member

No, it's the second commit. // Fall through is a magic comment that gcc recognizes.

This comment has been minimized.

Sign in to view
Copy link
@jasnell

jasnell Jan 17, 2018

Member

ah.... I don't think I ever knew that... good to know :-)

@jasnell jasnell referenced this pull request Jan 17, 2018

Closed

src: remove unused variable in node_file #18200

2 of 2 tasks complete
@jasnell

jasnell approved these changes Jan 17, 2018
View changes

@addaleax

addaleax approved these changes Jan 18, 2018
View changes

@addaleax addaleax added the author ready label Jan 18, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Jan 18, 2018

CI: https://ci.nodejs.org/job/node-test-commit/15505/
@mhdawson

mhdawson approved these changes Jan 18, 2018
View changes

Copy link
Member

mhdawson left a comment

LGTM
@BridgeAR

BridgeAR approved these changes Jan 19, 2018
View changes

@BridgeAR BridgeAR added the fast-track label Jan 19, 2018

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Jan 19, 2018

Landed in 5f64787, 11a26e1

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 19, 2018

@bnoordhuis @BridgeAR
src: fix -Wunused-but-set-variable warnings 
PR-URL: nodejs#18205
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
5f64787

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 19, 2018

@bnoordhuis @BridgeAR
src: fix -Wimplicit-fallthrough warning 
PR-URL: nodejs#18205
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
11a26e1

@BridgeAR BridgeAR closed this Jan 19, 2018

evanlucas added a commit that referenced this pull request Jan 30, 2018

@bnoordhuis @evanlucas
src: fix -Wimplicit-fallthrough warning 
PR-URL: #18205
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
9132367

@evanlucas evanlucas referenced this pull request Jan 30, 2018

Merged

v9.5.0 release proposal #18464

evanlucas added a commit that referenced this pull request Jan 30, 2018

@bnoordhuis @evanlucas
src: fix -Wimplicit-fallthrough warning 
PR-URL: #18205
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1c8df28

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

@bnoordhuis @msoechting
src: fix -Wunused-but-set-variable warnings 
PR-URL: nodejs#18205
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
d00cd31

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

@bnoordhuis @msoechting
src: fix -Wimplicit-fallthrough warning 
PR-URL: nodejs#18205
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
80f83d1

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

@bnoordhuis @msoechting
src: fix -Wunused-but-set-variable warnings 
PR-URL: nodejs#18205
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ffd10bc

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

@bnoordhuis @msoechting
src: fix -Wimplicit-fallthrough warning 
PR-URL: nodejs#18205
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
68da2c1

@MylesBorins MylesBorins added the dont-land-on-v9.x label Feb 20, 2018

@MylesBorins

This comment has been minimized.

Sign in to view
Copy link
Member

MylesBorins commented Feb 20, 2018

It seems as those both of these patches don't need to be applied to v9.x, cherry pick applies empty. Not sure what is going on

@MylesBorins MylesBorins added dont-land-on-v6.x dont-land-on-v8.x labels Feb 27, 2018

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

@bnoordhuis @MayaLekova
src: fix -Wunused-but-set-variable warnings 
PR-URL: nodejs#18205
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
96f4bfd

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

@bnoordhuis @MayaLekova
src: fix -Wimplicit-fallthrough warning 
PR-URL: nodejs#18205
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
988bc3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.