★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/17777Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm 5.6.0 #17777

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@jasnell jasnell

@addaleax addaleax

@targos targos

@BridgeAR BridgeAR

@gibfahn gibfahn

@iarna iarna

Assignees
No one assigned
Labels
dont-land-on-v8.x npm
Projects
None yet
Milestone
No milestone
8 participants
@MylesBorins @gibfahn @jasnell @addaleax @targos @BridgeAR @nodejs-github-bot @zkat
@MylesBorins
Copy link
Member

MylesBorins commented Dec 20, 2017

#17535 directly targeted v9.x-staging as npm 5.6.0 explicitly fails on 10.x (and thus fails on master)

This PR cherry-picks the original 5.6.0 upgrade from the 9.x-staging branch and includes a floated patch to force npm support on 10.x. I would not like to see master falling behind a release stream for vendored dependencies.

Didn't want to block updating the release so I've moved the conversation here

@zkat @iarna do you have any objections to us doing this?

zkat and others added some commits Dec 7, 2017

@zkat @MylesBorins
deps: upgrade npm to 5.6.0 
PR-URL: #17535
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
07b36c8
@MylesBorins
deps: manually add 10.x support to npm 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: #17535
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
48ab33b

@MylesBorins MylesBorins requested a review from iarna Dec 20, 2017

@nodejs-github-bot nodejs-github-bot added the npm label Dec 20, 2017

@targos

targos approved these changes Dec 20, 2017
View changes

@jasnell

jasnell approved these changes Dec 20, 2017
View changes

@BridgeAR

BridgeAR approved these changes Dec 21, 2017
View changes

@addaleax

addaleax approved these changes Dec 27, 2017
View changes

@gibfahn

gibfahn approved these changes Dec 28, 2017
View changes

@gibfahn

This comment has been minimized.

Sign in to view
Copy link
Member

gibfahn commented Dec 28, 2017

LGTM for now, but not a fan of having to patch npm for every major version of node. This also seems like something that will complicate backports.
@MylesBorins

This comment has been minimized.

Sign in to view
Copy link
Member Author

MylesBorins commented Jan 19, 2018

landed in bfe41fe...cbd6349

@MylesBorins MylesBorins closed this Jan 19, 2018

MylesBorins added a commit that referenced this pull request Jan 19, 2018

@zkat @MylesBorins
deps: upgrade npm to 5.6.0 
PR-URL: #17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
d3b1c97

MylesBorins added a commit that referenced this pull request Jan 19, 2018

@MylesBorins
deps: manually add 10.x support to npm 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: #17535
PR-URL: #17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
cbd6349

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

@zkat @msoechting
deps: upgrade npm to 5.6.0 
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
1e8976a

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

@MylesBorins @msoechting
deps: manually add 10.x support to npm 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: nodejs#17535
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
7ba5a39

@richardlau richardlau referenced this pull request Feb 5, 2018

Closed

deps: update npm to v5.5.1 #16509

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

@zkat @msoechting
deps: upgrade npm to 5.6.0 
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
c106a8d

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

@MylesBorins @msoechting
deps: manually add 10.x support to npm 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: nodejs#17535
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
36816a8

@MylesBorins MylesBorins added dont-land-on-v8.x dont-land-on-v9.x labels Feb 20, 2018

FallenRiteMonk added a commit to FallenRiteMonk/node that referenced this pull request Mar 26, 2018

@MylesBorins @FallenRiteMonk
deps: manually add 10.x support to npm 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: nodejs#17535
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
43ae658

MylesBorins added a commit to FallenRiteMonk/node that referenced this pull request Apr 5, 2018

@MylesBorins
deps: manually add 10.x support to npm 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: nodejs#17535
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
8f15080

MylesBorins added a commit that referenced this pull request Apr 5, 2018

@MylesBorins
deps: manually add 10.x support to npm 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: #17535
Backport-PR-URL: #19560
PR-URL: #17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
55557ba

MylesBorins added a commit to MylesBorins/node that referenced this pull request Apr 5, 2018

@MylesBorins
deps: manually add 10.x support to npm 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: nodejs#17535
Backport-PR-URL: nodejs#19560
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
c26d8c2

MylesBorins added a commit to MylesBorins/node that referenced this pull request Apr 5, 2018

@MylesBorins
deps: manually add 10.x support to npm 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: nodejs#17535
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
3527dc0

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

@zkat @MayaLekova
deps: upgrade npm to 5.6.0 
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
f2fac54

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

@MylesBorins @MayaLekova
deps: manually add 10.x support to npm 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: nodejs#17535
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
b2f8a91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.