lib: remove some useless assignments

PR-URL: #23199 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs · Sep 25, 2018 · 6c8a73de331a5dd5b060f8f50cd3c1ac72f4d583 · 6c8a73d
1 parent d881b33
commit 6c8a73de331a5dd5b060f8f50cd3c1ac72f4d583
Unified Split

Showing with 2 additions and 6 deletions.

+1 −1 lib/events.js

+1 −1 lib/internal/readline.js

+0 −4 lib/net.js
diff --git a/lib/events.js b/lib/events.js
@@ -224,7 +224,7 @@ function _addListener(target, type, listener, prepend) {
  if (existing === undefined) {
    // Optimize the case of one listener. Don't need the extra array object.
-  
-    existing = events[type] = listener;
+  
+    events[type] = listener;
    ++target._eventsCount;
  } else {
    if (typeof existing === 'function') {

diff --git a/lib/internal/readline.js b/lib/internal/readline.js
@@ -258,7 +258,7 @@ function* emitKeys(stream) {
          s += (ch = yield);
          if (ch >= '0' && ch <= '9') {
-  
-            s += (ch = yield);
+  
+            s += yield;
          }
        }

diff --git a/lib/net.js b/lib/net.js
@@ -1056,10 +1056,6 @@ function afterConnect(status, handle, req, readable, writable) {
    return;
  }
-  
-  // Update handle if it was wrapped
-  
-  // TODO(indutny): assert that the handle is actually an ancestor of old one
-  
-  handle = self._handle;
-  
-
  debug('afterConnect');
  assert(self.connecting);