deps: V8: fix filename manipulation for Windows

Backport-PR-URL: #28955 PR-URL: #28016 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs · Mar 31, 2019 · 040e7dabe40b8dabf101c84f82802dcea6e52042 · 040e7da
1 parent b04f9e1
commit 040e7dabe40b8dabf101c84f82802dcea6e52042
Unified Split

Showing with 11 additions and 3 deletions.

+1 −1 common.gypi

+5 −1 deps/v8/src/snapshot/embedded/platform-embedded-file-writer-win.cc

+5 −1 deps/v8/src/torque/csa-generator.cc
diff --git a/common.gypi b/common.gypi
@@ -38,7 +38,7 @@
    # Reset this number to 0 on major V8 upgrades.
    # Increment by one for each non-official patch applied to deps/v8.
-  
-    'v8_embedder_string': '-node.0',
+  
+    'v8_embedder_string': '-node.1',
    ##### V8 defaults for Node.js #####

diff --git a/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-win.cc b/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-win.cc
@@ -569,7 +569,11 @@ void PlatformEmbeddedFileWriterWin::DeclareExternalFilename(
  // Replace any Windows style paths (backslashes) with forward
  // slashes.
  std::string fixed_filename(filename);
-  
-  std::replace(fixed_filename.begin(), fixed_filename.end(), '\\', '/');
+  
+  for (auto& c : fixed_filename) {
+  
+    if (c == '\\') {
+  
+      c = '/';
+  
+    }
+  
+  }
  fprintf(fp_, ".file %d \"%s\"\n", fileid, fixed_filename.c_str());
 }

diff --git a/deps/v8/src/torque/csa-generator.cc b/deps/v8/src/torque/csa-generator.cc
@@ -56,10 +56,14 @@ Stack<std::string> CSAGenerator::EmitBlock(const Block* block) {
 }
 void CSAGenerator::EmitSourcePosition(SourcePosition pos, bool always_emit) {
-  
-  const std::string& file = SourceFileMap::GetSource(pos.source);
+  
+  std::string file = SourceFileMap::GetSource(pos.source);
  if (always_emit || !previous_position_.CompareStartIgnoreColumn(pos)) {
    // Lines in Torque SourcePositions are zero-based, while the
    // CodeStubAssembler and downwind systems are one-based.
+  
+    for (auto& c : file) {
+  
+      if (c == '\\')
+  
+        c = '/';
+  
+    }
    out_ << "    ca_.SetSourcePosition(\"" << file << "\", "
         << (pos.start.line + 1) << ");\n";
    previous_position_ = pos;