★ wanayoo — archive 1999 https://github.com/nodejs/llnode/pull/344Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use official CI badge #344

Open
wants to merge 2 commits into
base: master
from
Open

doc: use official CI badge #344

wants to merge 2 commits into from

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Mar 5, 2020

No description provided.

gengjiawen added 2 commits Mar 5, 2020
Copy link
Member

@mmarchini mmarchini left a comment

Humm, will check tomorrow, but the official one seems to be for the last status regardless if the build was on a PR or on master, whereas the shields badge will get the last result only from master? Otherwise lgtm

@gengjiawen
Copy link
Member Author

@gengjiawen gengjiawen commented Mar 5, 2020

Humm, will check tomorrow, but the official one seems to be for the last status regardless if the build was on a PR or on master, whereas the shields badge will get the last result only from master? Otherwise lgtm

The shields version is broken, not sure why. As the icon page suggest the badge is for the default branch. You can lock to master branch too.

@mmarchini
Copy link
Member

@mmarchini mmarchini commented Mar 6, 2020

Oh, nice catch. There was a typo on the Shields URL (push instead of on%20push%20or%20pull_request). Do you mind updating the URL to keep using shield (so that all three badges look the same)? The correct url should be https://img.shields.io/github/workflow/status/nodejs/llnode/on%20push%20or%20pull_request/master?style=flat-square

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.