Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upjenkins: update to use pipeline #178
Merged
Conversation
Refs: nodejs-private/secrets#20 Refs: #175 Will now post comments upon pipeline builds being run
|
@phillipj, would you be able to review/push the secrets updates, and then review/push this PR? |
|
Although I don't know these new endpoints in detail, the changes LGTM. |
Sure! I'll get this pushed later tonight. |
|
This is now live in production. |
This was referenced Jun 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
maclover7 commentedJun 9, 2018
Refs: nodejs-private/secrets#20
Refs: #175
Will now post comments upon pipeline builds being run