★ wanayoo — archive 1999 https://github.com/nodejs/docker-node/pull/1209Nouvelle recherche | Portail wanayoo
Skip to content

/ docker-node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #1209 from PeterDaveHello/update-node.js #1209

Merged
merged 1 commit into from Feb 6, 2020
Merged

Merge pull request #1209 from PeterDaveHello/update-node.js #1209

merged 1 commit into from Feb 6, 2020

Conversation

@PeterDaveHello
Copy link
Member

PeterDaveHello commented Feb 6, 2020 •
edited

Except v13 for Alpine Linux

See:
@PeterDaveHello PeterDaveHello requested a review from nodejs/docker Feb 6, 2020
@nschonni
nschonni requested changes Feb 6, 2020
View changes
Copy link
Member

nschonni left a comment

Looks like a few of the unofficial Alpine builds didn't finish yet, or it the missing shas issue still being tracked on the nodejs/build repo
13/alpine3.10/Dockerfile Outdated
@@ -12,7 +12,7 @@ RUN addgroup -g 1000 node \
&& case "${alpineArch##*-}" in \
x86_64) \
ARCH='x64' \
CHECKSUM="4c153345a08d2eeb40dfbb62f1ef6ade7ec369630f9cf9f061bf9d52b10acafc" \
CHECKSUM="" \

This comment has been minimized.

Sign in to view
@nschonni

nschonni Feb 6, 2020 Member

Looks like this didn't finish yet

This comment has been minimized.

Sign in to view
@PeterDaveHello

PeterDaveHello Feb 6, 2020 Author Member

Yeah I forgot to use "WIP" PR, I'll use PR title to indicate that.
13/alpine3.11/Dockerfile Outdated
@@ -12,7 +12,7 @@ RUN addgroup -g 1000 node \
&& case "${alpineArch##*-}" in \
x86_64) \
ARCH='x64' \
CHECKSUM="4c153345a08d2eeb40dfbb62f1ef6ade7ec369630f9cf9f061bf9d52b10acafc" \
CHECKSUM="" \

This comment has been minimized.

Sign in to view
@nschonni

nschonni Feb 6, 2020 Member

Also missing
@PeterDaveHello PeterDaveHello changed the title Update Node.js 10, 12, 13 for 2020-01 security updates [WIP] Update Node.js 10, 12, 13 for 2020-01 security updates Feb 6, 2020
@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Feb 6, 2020

@rvagg is there any chance we can help speed to the unofficial build for Alpine Linux?
@rvagg
Copy link
Member

rvagg commented Feb 6, 2020

build failed, the release went out unsigned nodejs/node#31657 (no SHASUMS.txt.asc)
@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Feb 6, 2020

Didn't notice that, thanks!
@dominykas
Copy link
Member

dominykas commented Feb 6, 2020

Is only v13.8.0 affected? Would it make sense to skip it in this PR, and have a separate PR for it, possibly making sure that 10.x/12.x are available faster for people to use?
@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Feb 6, 2020

Is only v13.8.0 affected? Would it make sense to skip it in this PR, and have a separate PR for it, possibly making sure that 10.x/12.x are available faster for people to use?

Yes, and it's only Alpine Linux build, it's possible to ship the other versions and the other builds first, @nodejs/docker what do you think?
@SimenB
Copy link
Member

SimenB commented Feb 6, 2020

It's not the alpine build, 13.8.0 is missing for all variants (https://nodejs.org/dist/v13.8.0/SHASUMS256.txt.asc) which is why CI is failing. v10 and v12 works for all distros.

So rolling back the updates to node 13 and keeping 10 and 12 makes sense to me. Those are the LTS versions anyways, which hopefully is what most people are running in production
@BethGriggs
Copy link
Member

BethGriggs commented Feb 6, 2020

Ah sorry, the SHASUMS for v13.8.0 should now be available
@BethGriggs BethGriggs closed this Feb 6, 2020
@BethGriggs BethGriggs reopened this Feb 6, 2020
@SimenB
Copy link
Member

SimenB commented Feb 6, 2020

Thanks @BethGriggs! @rvagg does that mean the alpine versions of v13 will be available soon?
@vogsphar
Copy link

vogsphar commented Feb 6, 2020

https://nodejs.org/dist/v13.8.0/SHASUMS256.txt.asc is there
@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Feb 6, 2020

It's not the alpine build, 13.8.0 is missing for all variants (nodejs.org/dist/v13.8.0/SHASUMS256.txt.asc) which is why CI is failing. v10 and v12 works for all distros.

So rolling back the updates to node 13 and keeping 10 and 12 makes sense to me. Those are the LTS versions anyways, which hopefully is what most people are running in production

Oh I mean the "unofficial" build, sorry for the confusing.
@SimenB
Copy link
Member

SimenB commented Feb 6, 2020

At the time of your comment, "official" builds for v13 was also broken.

Now though those should be fixed, so if you rollback v13 for alpine and force push to trigger new CI, we should be good to go
@PeterDaveHello PeterDaveHello force-pushed the PeterDaveHello:update-node.js branch from 5a52fd0 to 9d02541 Feb 6, 2020
@SimenB
SimenB approved these changes Feb 6, 2020
View changes
Copy link
Member

SimenB left a comment

perfect! 👍
@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Feb 6, 2020

Let's see ;)
@PeterDaveHello PeterDaveHello changed the title [WIP] Update Node.js 10, 12, 13 for 2020-01 security updates Update Node.js 10, 12, 13 for 2020-01 security updates (Except v13 for Alpine) Feb 6, 2020
@PeterDaveHello PeterDaveHello changed the title Update Node.js 10, 12, 13 for 2020-01 security updates (Except v13 for Alpine) Update Node.js 10, 12, 13 for 2020-01 security updates Feb 6, 2020
@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Feb 6, 2020

v13 unofficial build has arrived!
@PeterDaveHello PeterDaveHello force-pushed the PeterDaveHello:update-node.js branch from 9d02541 to a0ebd1d Feb 6, 2020
@djmitche
Copy link

djmitche commented Feb 6, 2020

Fixes #2010.
@djmitche djmitche mentioned this pull request Feb 6, 2020
Closed
@SimenB
Copy link
Member

SimenB commented Feb 6, 2020 •
edited

CI is unhappy...

Unable to connect to security-cdn.debian.org:http: Fetched 13.8 MB in 30s (453 kB/s) E: Failed to fetch http://security-cdn.debian.org/debian-security/pool/updates/main/c/cyrus-sasl2/libsasl2-modules-db_2.1.27+dfsg-1+deb10u1_amd64.deb

I've restarted the two failing builds
@SimenB SimenB mentioned this pull request Feb 6, 2020
Closed
@SimenB
Copy link
Member

SimenB commented Feb 6, 2020

That fixed CI, but Alpine v13 are still wrong. Those need to be reverted
@PeterDaveHello @SimenB
Update Node.js 10, 12, 13 for 2020-01 security updates
Verified
This commit was signed with a verified signature.
SimenB Simen Bekkhus
GPG key ID: E3BEC11885DC91B6 Learn about signing commits
Loading status checks…
46f5203 
v10.18.1 -> v10.19.0, v12.14.1 -> v12.15.0, v13.7.0 -> v13.8.0

See:

- https://nodejs.org/en/blog/release/v10.19.0
- https://nodejs.org/en/blog/release/v12.15.0
- https://nodejs.org/en/blog/release/v13.8.0
@SimenB SimenB force-pushed the PeterDaveHello:update-node.js branch from a0ebd1d to 46f5203 Feb 6, 2020
@SimenB
Copy link
Member

SimenB commented Feb 6, 2020

I did so now and pushed. I'll merge if CI is happy
@SimenB SimenB changed the title Update Node.js 10, 12, 13 for 2020-01 security updates Merge pull request #1209 from PeterDaveHello/update-node.js Feb 6, 2020
@SimenB SimenB merged commit d143677 into nodejs:master Feb 6, 2020
2 checks passed
2 checks passed
eclint
Details
Travis CI - Pull Request Build Passed
Details
@nodejs-github-bot nodejs-github-bot mentioned this pull request Feb 6, 2020
Merged
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 6, 2020

Created PR to the official-images repo (docker-library/official-images#7429). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.
@SimenB
Copy link
Member

SimenB commented Feb 6, 2020

Node 13 are missing their updates for alpine as https://unofficial-builds.nodejs.org/download/release/v13.8.0/SHASUMS256.txt is not available at this time
@rvagg
Copy link
Member

rvagg commented Feb 7, 2020

https://unofficial-builds.nodejs.org/download/release/v13.8.0/ available now
@PeterDaveHello PeterDaveHello deleted the PeterDaveHello:update-node.js branch Feb 7, 2020
PeterDaveHello added a commit to PeterDaveHello/docker-node that referenced this pull request Feb 7, 2020
@PeterDaveHello
Add Node.js v13.8.0 unofficial build checksum for Alpine, cc nodejs#1209
d8cbaa1
PeterDaveHello added a commit to PeterDaveHello/docker-node that referenced this pull request Feb 7, 2020
@PeterDaveHello
Update Node.js v13 for Alpine to v13.8.0, cc nodejs#1209
5a27a54 
v13 update for Alpine Linux was missing due to the delay of unofficial
build for Alpine.
@PeterDaveHello PeterDaveHello mentioned this pull request Feb 7, 2020
Merged
@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Feb 7, 2020

I did so now and pushed. I'll merge if CI is happy

Thanks! It'll be even better if the commit message was also revise to record the changes next time ;)
@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Feb 7, 2020

Node.js v13 for Alpine was sent here: #1212 🎉
@sam-github sam-github mentioned this pull request Feb 7, 2020
Closed
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni

@SimenB SimenB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
@PeterDaveHello @rvagg @dominykas @SimenB @BethGriggs @vogsphar @djmitche @nodejs-github-bot @nschonni
You can’t perform that action at this time.