★ wanayoo — archive 1999 https://github.com/nodejs/core-validate-commit/issues/12Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a git hook #12

Open
srl295 opened this issue Oct 27, 2016 · 0 comments · May be fixed by #13
Open

Add a git hook #12

srl295 opened this issue Oct 27, 2016 · 0 comments · May be fixed by #13

Comments

@srl295
Copy link
Member

@srl295 srl295 commented Oct 27, 2016

Add a hook to call core-validate-commit when you check in

srl295 added a commit to srl295/core-validate-commit that referenced this issue Oct 27, 2016
Add instructions and a hook to call core-validate-commit from
git commits.

Depends on nodejs#11

Known issues:
- leaves ${TMPF} around (temporary file)
- probably will reject `fixup:` type commit logs
- may be too strict if someone is just doing a simple
'work in progress' kind of local branch

Larger improvement:
- fold the entire hook script into a mode, and/or an alternate
script entrypoint into core-validate-commit. This would drop
requirements on sh, sed, grep…

Fixes: nodejs#12
srl295 added a commit to srl295/core-validate-commit that referenced this issue Oct 27, 2016
Add instructions and a hook to call core-validate-commit from
git commits.

Depends on nodejs#11

Known issues:
- leaves ${TMPF} around (temporary file)
- probably will reject `fixup:` type commit logs
- may be too strict if someone is just doing a simple
'work in progress' kind of local branch

Larger improvement:
- fold the entire hook script into a mode, and/or an alternate
script entrypoint into core-validate-commit. This would drop
requirements on sh, sed, grep…

Fixes: nodejs#12
@srl295 srl295 linked a pull request that will close this issue Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.