Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReboot development #147
Open
Reboot development #147
Conversation
and others
added 30 commits
Oct 29, 2017
close connections properly in passive mode
Lib is unstable, be carefull!
This PR fixes a regression introduced in the latest refactoring:
TypeError [ERR_INVALID_ARG_TYPE]: The "value" argument must not be of type number. Received type number
at Function.from (buffer.js:215:11)
at FtpConnection._STOR_usingWriteFile (/data/node_modules/ftpd/lib/FtpConnection.js:1212:25)
at FtpConnection._command_STOR (/data/node_modules/ftpd/lib/FtpConnection.js:1122:10)
at checkData (/data/node_modules/ftpd/lib/FtpConnection.js:291:14)
at FtpConnection._onData (/data/node_modules/ftpd/lib/FtpConnection.js:279:9)
at Socket.socket.on (/data/node_modules/ftpd/lib/FtpServer.js:102:10)
I've tested the ftp file upload with this change and everything seems to work fine!
Fix file modes
Use Buffer.alloc instead of Buffer.from
This way tests can be executed in parrallel
|
@sstur I've setup the CI/CD this way that from my repository it will still release a new version whenever I push to my own master. Github action result The conflicts are because 2 files changed on both sides, but you should be able to accept my version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
svrooij commentedJun 27, 2020
Fixes #144
Also moved testing to Github actions instead of Travis