★ wanayoo — archive 1999 https://github.com/nodeftpd/nodeftpd/pull/145

Nouvelle recherche | Portail wanayoo

nodeftpd / nodeftpd

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitting RNTO command events. #145

Open

software-administrator wants to merge 2 commits into nodeftpd:master from Wattics:master

software-administrator commented Jun 22, 2020

No description provided.


        Emitting RNTO command events.

mk-pmb reviewed

lib/FtpConnection.js Outdated

  
            self.emit('file:rnto', status, {

              fileFrom: self.filefrom,

              fileTo: fileto,

              error: err

mk-pmb Jun 22, 2020 Contributor

I'd prefer an additional errorState: Boolean(err) like we have with the file:stor event, and error: (err || false) as a convenience to users to make property access (e.g. err.name, err.message) always safe.

software-administrator Jun 23, 2020 Author

Ok. Doing it. One extra question: Which are the most recent compatible node version for this project?

mk-pmb Jun 23, 2020 Contributor

I've no idea but I expect it to work with all Node.js LTS versions.


        Added extra data attributes in RNTO event to make it similar to file:…

1fd4316

…stor event data.

mk-pmb approved these changes

Contributor

mk-pmb commented Jun 23, 2020

Thanks! 👍

pedroaugusto commented Jun 24, 2020

You're welcome. What is the merge policy? I see a bunch of old PR's not yet merged.

software-administrator force-pushed the Wattics:master branch from 8ede57b to 1fd4316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.