abstractly declare install_requires #114
Closed
Conversation
|
Merged this into our fork, works good, thank you |
|
Do you have a maintained fork? I'd be happy to contribute to that -- it doesn't seem like there's much action on this repo. |
|
@simon-weber |
|
You guys can maintain a separate fork if you really want... or you can ask to be contributors on this one. That's what I did, and I'm going to merge this in here after verifying it works. |
|
Thanks for taking a look at the PR! I don't have time to help out with maintenance, sorry. |
|
I copied your changes into another PR, so I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Currently, the install_requires are all pinned/concrete. This causes dependency hell: python-lambda can't be installed unless the application using it (and all its dependencies) use the same versions of any shared requirements.
This PR switches to abstract requirements to fix this. I wasn't aware of any lower bounds, so I didn't add any.
There's more background on this on the pypa site, and a discussion of the same change in one of my projects.