Support type completion over JavaScript files #620
Merged
Conversation
typescript/libs/service_proxy.py
Outdated
| """ Add full type support for compilers running in file scope mode """ | ||
| compiler_options = { | ||
| "target": "ESNext", | ||
| "module": "CommonJS", |
DanielRosenwasser
Jan 26, 2018
Member
Is there a reason you had to change this to moduleResolution?
Is there a reason you had to change this to moduleResolution?
typescript/libs/service_proxy.py
Outdated
| @@ -38,6 +38,25 @@ def configure(self, host_info="Sublime Text", file=None, format_options=None): | |||
| if self.__worker_comm.started(): | |||
| self.__worker_comm.postCmd(json_str) | |||
|
|
|||
| self.set_compiler_options() | |||
|
|
|||
| def set_compiler_options(self): | |||
DanielRosenwasser
Jan 26, 2018
Member
set_inferred_project_compiler_options
set_inferred_project_compiler_options
|
So the name of the function is preventing this from being merged before two-year anniversary, or there is some dark and deep conspiracy going on? |
"set_inferred_project_compiler_options"
|
@DanielRosenwasser @a-software sorry for the late. I just forgot this pull request I've updated the inferred compiler option so that it only contains the minimized options. |
|
+1 |
|
Can we get this merged? |
7cd4b43
into
microsoft:master
1 check passed
1 check passed
This was referenced Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR is based on #570, with several fixes and improvements. Apologize if I offended anyone, but I couldn't see any update in #570 for nearly one year😢 .
This implement tries to behave as closely as possible to vscode by:
compilerOptionsForInferredProjectsfor file scope compilers,kind: "warning"from completion list.Screenshot:
