★ wanayoo — archive 1999 https://github.com/libgit2/libgit2sharp/pull/1510Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rebase Refactoring #1510

Open
wants to merge 4 commits into
base: master
from
Open

WIP: Rebase Refactoring #1510

wants to merge 4 commits into from

Conversation

@ethomson
Copy link
Member

@ethomson ethomson commented Nov 17, 2017

Goals:

  1. Move Rebase into the commands that we've started.
  2. Provide the ability to do in-memory / bare rebases.
ethomson added 4 commits Nov 17, 2017
Xunit 2.3 now considers it an error to pass a integer type when a
enum was expected.
Introduce a Rebase class that maps to the rebase object in libgit2 more
directly.
@BKSpurgeon
Copy link

@BKSpurgeon BKSpurgeon commented Dec 2, 2017

Hi there
first of all thank you for your contribution to the code base

I would like to know re: this refactoring - what is the reason/purpose for it?

rgds

Ben

@ethomson
Copy link
Member Author

@ethomson ethomson commented Dec 2, 2017

Ideally users would be able to do a rebase completely in memory, without touching the working directory, and with custom ODB, etc backends. This is well supported by libgit2 but LibGit2Sharp makes various assumptions and these configurations are difficult or impossible.

@BKSpurgeon
Copy link

@BKSpurgeon BKSpurgeon commented Dec 5, 2017

ok chrs. appreciate the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.