Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[WIP] Introduce pluggable Ref DB backends #1226
Conversation
| backend.References["refs/tags/broken3"] = new MockRefdbReference("the/type/filtering"); | ||
| backend.References["refs/tags/correct1"] = new MockRefdbReference(new ObjectId("be3563ae3f795b2b4353bcce3a527ad0a4f7f644")); | ||
|
|
||
| List<string> tags = repository.Tags.Select(r => r.CanonicalName).ToList(); |
| tx.Commit(); | ||
| } | ||
|
|
||
| Assert.Null(repo.Refs[myRef.CanonicalName]); |
jamill
Nov 2, 2015
Author
Member
This test is currently failing - I am not sure if it is due to an bug the LibGit2Sharp side, or in the libgit2 side.
-
The comments for the unlock call in refdb_backend.h seems like it might not reflect the current implementation? Looking at the code, libgit2 also returns 2 in update_target as a value for success in one place, and I am not sure how to interpret it...
-
In update_target in transaction.c, there is some logic that is allocating refs. Should these calls instead be targeting the refdb backend?
This test is currently failing - I am not sure if it is due to an bug the LibGit2Sharp side, or in the libgit2 side.
-
The comments for the unlock call in refdb_backend.h seems like it might not reflect the current implementation? Looking at the code, libgit2 also returns
2in update_target as a value for success in one place, and I am not sure how to interpret it... -
In update_target in transaction.c, there is some logic that is allocating refs. Should these calls instead be targeting the refdb backend?
Rodske
Apr 22, 2017
How did you go with this? Did you manage to get any further around resolving these issues?
How did you go with this? Did you manage to get any further around resolving these issues?
These changes have been sitting around for a while (builds upon a commit from @ethomson from 2013), and I wanted to see about moving this forward. This PR is not complete (yet), but there were some areas I wanted to bring up for discussion.