★ wanayoo — archive 1999 https://github.com/libgit2/libgit2sharp/pull/1073Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate NuGet deployment on merge #1073

Closed
wants to merge 1 commit into from
Closed

Automate NuGet deployment on merge #1073

wants to merge 1 commit into from

Conversation

@nulltoken
Copy link
Member

@nulltoken nulltoken commented Jun 4, 2015

Cross platform compatibility is ensured as part of the Pull Request lifecycle. Both Travis and AppVeyor should be green before a PR merged. Would the merge build fail, it would only be because of a network hiccup (which could be re-triggered in order to display green badges on the README).

This is an attempt at automating the NuGet publication.

If the appveyor tweaking is correct, upon a successful merge, the generated NuGet package will be automatically deployed.

Currently, only vNext and master branches are monitored by AppVeyor:

  • vNext: produces prerelease packages
  • master: produces stable packages

Some issues I can think of about this proposal:

  • Usage of the matrix: I'm under the impression that each job will trigger the deployment.
  • Would someone trigger a rebuild of a merged commit, how to avoid the repeated publication of the NuGet package? FWIW, I don't know for sure how nuget.org reacts to this, but I suspect that this should lead to some failure, which in turn would fail the build.

/cc @FeodorFitsner

@FeodorFitsner
Copy link
Contributor

@FeodorFitsner FeodorFitsner commented Jun 6, 2015

It won't be a failure of the package already exists - AppVeyor will just skip its deployment.

  • Feodor

On Thu, Jun 4, 2015 at 11:44 AM, nulltoken notifications@github.com
wrote:

Cross platform compatibility is ensured as part of the Pull Request lifecycle. Both Travis and AppVeyor should be green before a PR merged. Would the merge build fail, it would only be because of a network hiccup (which could be re-triggered in order to display green badges on the README).
This is an attempt at automating the NuGet publication.
If the appveyor tweaking is correct, upon a successful merge, the generated NuGet package will be automatically deployed.
Currently, only vNext and master branches are monitored by AppVeyor:

  • vNext: produces prerelease packages
  • master: produces stable packages
    Some issues I can think of about this proposal:
  • Usage of the matrix: I'm under the impression that each job will trigger the deployment.
  • Would someone trigger a rebuild of a merged commit, how to avoid the repeated publication of the NuGet package? FWIW, I don't know for sure how nuget.org reacts to this, but I suspect that this should lead to some failure, which in turn would fail the build.
    /cc @FeodorFitsner
    You can view, comment on, or merge this pull request online at:
    #1073
    -- Commit Summary --
@nulltoken
Copy link
Member Author

@nulltoken nulltoken commented Jun 6, 2015

@FeodorFitsner Thanks!

Thoughts:

  • Do not use the current build datetime as the pre-release package suffix (as they would differ on the x86 and amd64 jobs)
  • Use the merge commit datetime (As we now prefer using GitHub UI for merges, it should be safe to rely on this datetime, as it always will be incrementing). This should still allow NuGet to consider each new prerelease package as more recent than the previous ones.
  • The merge commit timestamp is currently exposed by AppVeyor through the APPVEYOR_REPO_COMMIT_TIMESTAMP environment variable
  • A tiny problem is that the current variable content looks ambiguous with regards to UTC/local eg. 9/5/2014 1:06:05 PM. (cf. appveyor/ci#289).
@nulltoken nulltoken force-pushed the ntk/nuget branch 2 times, most recently from 8f1c23e to ae4970c Jul 12, 2015
@nulltoken nulltoken force-pushed the ntk/nuget branch from f46ea91 to 2d9607c Jul 14, 2015
@bording bording closed this Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.