Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix the test for HTTP protocol upgrade #461
Merged
Conversation
If the HTTP client wants to request protocol upgrade, it must send the `Upgrade` header. It should also set the `Connection` header. This test didn't do that, so conforming implementations could reject the `request.upgrade()` call. The fix is simple: add the 2 headers on the client side (i.e., in the test). To be able to set `Connection` and `Upgrade` headers on the `java.net.HttpURLConnection`, restricted headers must be allowed by setting a special system property. See also https://developer.mozilla.org/en-US/docs/Web/HTTP/Protocol_upgrade_mechanism and the Servlet specification 4.0, section 2.3.3.5.
|
Nice! |
7471ec9
into
javaee-samples:master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ladicek commentedMay 7, 2020
If the HTTP client wants to request protocol upgrade, it must
send the
Upgradeheader. It should also set theConnectionheader. This test didn't do that, so conforming implementations
could reject the
request.upgrade()call. The fix is simple:add the 2 headers on the client side (i.e., in the test).
To be able to set
ConnectionandUpgradeheaders on thejava.net.HttpURLConnection, restricted headers must be allowedby setting a special system property.
See also https://developer.mozilla.org/en-US/docs/Web/HTTP/Protocol_upgrade_mechanism
and the Servlet specification 4.0, section 2.3.3.5.