★ wanayoo — archive 1999 https://github.com/intercom/intercom-java/pull/252Nouvelle recherche | Portail wanayoo
Skip to content

/ intercom-java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversation message fixes #252

Open
wants to merge 2 commits into
base: master
from
Open

Conversation message fixes #252

wants to merge 2 commits into from

Conversation

@lukas-krecan-lt
Copy link

@lukas-krecan-lt lukas-krecan-lt commented Jan 30, 2019

Why?

I need to see real type of the conversation message and delivered_as field

How?

See the PR
@lukas-krecan-lt
Adding conversation_message.delivered_as
0e17813
@lukas-krecan-lt lukas-krecan-lt force-pushed the adleritech:master branch from 3658f77 to 4affbd1 Jan 30, 2019
@lukas-krecan-lt
Adding real type of conversation message
Loading status checks…
5ac50dd 
I was afraid to change the “type” field since it would have been backward incompatible change
@lukas-krecan-lt lukas-krecan-lt force-pushed the adleritech:master branch from 4affbd1 to 5ac50dd Jan 30, 2019
@alexshultsg
alexshultsg approved these changes Jun 17, 2019
View changes
@alexshultsg
alexshultsg suggested changes Nov 11, 2019
View changes
Copy link
Contributor

@alexshultsg alexshultsg left a comment

Don't you also need to update superclass overrides?
@alexshultsg
alexshultsg approved these changes Dec 4, 2019
View changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshultsg alexshultsg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@lukas-krecan-lt @alexshultsg
You can’t perform that action at this time.