Add conversation participants support #241
Open
Conversation
| @@ -178,7 +183,7 @@ private HttpURLConnection initializeConnection(URI uri, String method) throws IO | |||
| } | |||
|
|
|||
| private boolean shouldSkipResponseEntity(JavaType javaType, HttpURLConnection conn, int responseCode) { | |||
| return responseCode == 204 || Void.class.equals(javaType.getRawClass()) || "DELETE".equals(conn.getRequestMethod()); | |||
| return responseCode == 204 || Void.class.equals(javaType.getRawClass()); | |||
thewheat
Oct 28, 2018
Author
Contributor
Needed to parse response data. But in further testing this breaks Tag.delete
Needed to parse response data. But in further testing this breaks Tag.delete
|
Should not be merged as it breaks |
|
@thewheat ok .. will leave this for now and focus on other open PRs |
|
For reference PR to parse Will need to merge that first before merging this |
d1a24e8
to
7b4f618
7b4f618
to
4b63f9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Adding support for adding and removing of participants from group conversations
Participantclass as we're usingCustomerin the response for conversations ratings #235 and also in the return response for the added methodsRelated Docs: