Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up#1929: Protect logging debug calls with isDebugEnabled() #1930
Conversation
Description: Protect against potential performance degradation from debug logging by utilizing the logging libraries isDebugEnabled() check directly. Changes: * Protected all Logger.debug(...) calls with Logger.isDebugEnabled() Unit Tests: * N/A
|
I am happy with that. @bbakerman opinion? |
|
Thanks @andimarek . I've resolved the conflicts. Hopefully I did it correctly but let me know if there are any issues. |
|
@bbakerman checking in to see your take on this PR? I've resolved the conflicts per @andimarek request |
|
Thanks for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description:
Protect against potential performance degradation from debug logging by
utilizing the logging libraries isDebugEnabled() check directly.
Changes:
Unit Tests: