★ wanayoo — archive 1999 https://github.com/graphql-java/graphql-java/pull/1735Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: comments on interface arguments cause wrong error for schema validation #1735

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@andimarek
Copy link
Member

@andimarek andimarek commented Jan 14, 2020

bugfix: comments on nodes should not considered when comparing arguments of interface vs implementation.

This fixes #1701

…nts, therefore using printCompact
@bbakerman bbakerman merged commit b5692e4 into master Jan 14, 2020
3 checks passed
3 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@andimarek
Copy link
Member Author

@andimarek andimarek commented Jan 17, 2020

This will not be backported to 9.x because the fix relies on the printAstCompact behaviour not to print comments, which is not available in 9.x

@andimarek andimarek deleted the fix-argument-comments branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.