Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upNon-null input object fields with default values should be valid #1589
Conversation
| @@ -11,16 +11,28 @@ import static graphql.schema.idl.TypeRuntimeWiring.newTypeWiring | |||
| // See https://github.com/facebook/graphql/pull/418 | |||
| class IssueNonNullDefaultAttribute extends Specification { | |||
| def spec = ''' | |||
| input Locale { | |||
craigkost
Jul 3, 2019
Author
Not sure if it is acceptable to extend this test or if you would prefer a new test class added.
Not sure if it is acceptable to extend this test or if you would prefer a new test class added.
|
Thanks for this. we will look a little more into the base problem but I think this looks pretty good as an improvement to the code base |
andimarek
added a commit
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Update query validation to take default value for input object fields into account.
This should not break existing functionality but instead allow additional requests to pass validation. It should improve compliance with graphql/graphql-spec#418
Addresses: #1588