★ wanayoo — archive 1999 https://github.com/graphql-java/graphql-java/pull/1445Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for visiting fragment definitions in QueryVisitor. #1445

Merged
merged 5 commits into from Mar 11, 2019

Conversation

@tsroka
Copy link
Member

@tsroka tsroka commented Mar 5, 2019

No description provided.

Copy link
Member

@bbakerman bbakerman left a comment

Nice one

Copy link
Member

@andimarek andimarek left a comment

nice ... see my comments about naming

@andimarek andimarek added this to the 12.0 milestone Mar 10, 2019
@tsroka
Copy link
Member Author

@tsroka tsroka commented Mar 11, 2019

nice ... see my comments about naming

Renamed as per your comments and added #toString

@andimarek andimarek changed the title Add support for visiting fragments in QueryVisitor. Add support for visiting fragment definitions in QueryVisitor. Mar 11, 2019
Copy link
Member

@andimarek andimarek left a comment

typo ... otherwise ready to be merged

@@ -20,7 +21,7 @@ import static graphql.schema.GraphQLList.list
import static graphql.schema.GraphQLNonNull.nonNull
import static java.util.Collections.emptyMap

class QueryTraversalTest extends Specification {
class QueryTrqaversalTest extends Specification {

This comment has been minimized.

@andimarek

andimarek Mar 11, 2019
Member

typo :-)

@andimarek andimarek merged commit 52a7b6e into graphql-java:master Mar 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.