★ wanayoo — archive 1999 https://github.com/graphql-java/graphql-java/pull/1221Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1210 deferred aligned with apollo #1221

Merged
merged 39 commits into from Jun 12, 2019
Merged

Conversation

@andimarek
Copy link
Member

@andimarek andimarek commented Sep 13, 2018

note: this is a second PR directly from this repo in order to deploy it while in development

See #1210

Copy link
Member Author

@andimarek andimarek left a comment

see my comments .... @bbakerman great work!


import java.util.List;

public abstract class DeferredDirectiveAbstractRule extends AbstractRule {

This comment has been hidden.

@andimarek

andimarek Sep 15, 2018
Author Member

should be Internal


import java.util.List;

public class DeferredDirectiveOnNonNullableField extends DeferredDirectiveAbstractRule {

This comment has been hidden.

@andimarek

andimarek Sep 15, 2018
Author Member

should be Internal

Directive directive = field.getDirective(Directives.DeferDirective.getName());
if (directive != null) {
Map<String, Object> argumentValues = valuesResolver.getArgumentValues(Directives.DeferDirective.getArguments(), directive.getArguments(), variables);
return (Boolean) argumentValues.get("if");

This comment has been minimized.

@andimarek

andimarek Sep 15, 2018
Author Member

can this be null? => unboxing will cause NPE

This comment has been minimized.

@bbakerman

bbakerman Mar 15, 2019
Member

no - its default is true

This comment has been minimized.

@bbakerman

bbakerman Mar 15, 2019
Member

now made it non null as an arg declaration

echo "Building on master"
BUILD_COMMAND="./gradlew clean assemble && ./gradlew check --info && ./gradlew bintrayUpload -x check --info"
fi

This comment has been minimized.

@andimarek

andimarek Sep 15, 2018
Author Member

we must remember that must be changed again before merge!

This comment has been minimized.

@bbakerman

bbakerman Mar 15, 2019
Member

you did that

andimarek added 2 commits Sep 16, 2018
fix SubscriberPublisher test: should throw NPE
@michaelshiel
Copy link

@michaelshiel michaelshiel commented Nov 17, 2018

I'm wondering what the status of this branch is? It's very important for my project (and seems to work well). Would you like help cleaning/documenting to get it merged? Just point me in the right direction 👍

@andimarek
Copy link
Member Author

@andimarek andimarek commented Nov 19, 2018

@bbakerman your opinion on the current state of it?

@andimarek
Copy link
Member Author

@andimarek andimarek commented Dec 15, 2018

the implementation here looks good, but it is not fully tested and we will not merge it soon.

@Me1kaa
Copy link

@Me1kaa Me1kaa commented Dec 25, 2018

There is a valuable feature because current deferred has a problem with matching paths. So, is any forecasts of that feature? We want to use it, and here is the question: wait for this PR will be merged or use this branch or maybe do the fork? Do the tests is the main problem with that branch(maybe the community can help)? And Merry Xmas!

@Me1kaa
Copy link

@Me1kaa Me1kaa commented Dec 26, 2018

By now, I just downloaded rep. Checkout to that branch and merged it with v11.0 and uploaded it to my company's rep(so after all tests was excellent). That's an easy solution, but I hope that will be merged soon.
@michaelshiel, so, if you're really in need - do the same.

@andimarek
Copy link
Member Author

@andimarek andimarek commented Dec 28, 2018

@Me1kaa I can't give you a forecast when we will continue working on that, sorry. so yes: if it is urgent for you I would recommend to build this brand yourself for now.

@bbakerman bbakerman added this to the 13.0 milestone Mar 20, 2019
bbakerman added 2 commits May 14, 2019
@bbakerman
Copy link
Member

@bbakerman bbakerman commented May 14, 2019

This is now ready to go

@bbakerman bbakerman merged commit 0fec4be into master Jun 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@andimarek andimarek deleted the 1210-deferred-aligned-with-apollo branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.