Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Update configure and bootstrap, fix compiler warnings in http_endpoin… #205
Conversation
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 95.63% 95.63%
=======================================
Files 35 35
Lines 3230 3230
=======================================
Hits 3089 3089
Misses 141 141
Continue to review full report at Codecov.
|
| { | ||
| return family_url; | ||
| } | ||
|
|
||
| const bool is_regex_compiled() const | ||
| const bool is_regex_compiled() |
etr
Aug 8, 2020
Owner
what was the issue with the is_family_url and is_regex_compiled methods being const?
what was the issue with the is_family_url and is_regex_compiled methods being const?
|
Compiler warning. It has const before it still.
…On Fri, Aug 7, 2020, 9:20 PM Sebastiano Merlino ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/httpserver/details/http_endpoint.hpp
<#205 (comment)>:
> {
return family_url;
}
- const bool is_regex_compiled() const
+ const bool is_regex_compiled()
what was the issue with the is_family_url and is_regex_compiled methods
being const?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#205 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIGB3CZYNDJWEEDYN2M55NTR7TABTANCNFSM4PYIFNTA>
.
|
|
Got it. I think the real issue is the "const bool" (which makes no sense). Does using "bool is_regex_compiled() const" cause you any warning? Effectively we want the method to be declared as not modifying the object so I am not sure what the warning against that is. |
|
As is:
In file included from
../lib/include/httpserver/webserver.hpp:46:../lib/include/httpserver/de
tails/http_endpoint.hpp:123:9: warning: 'const' type qualifier on
return type has no effect [-Wignored-qualifiers] const bool
is_family_url()
const ^~~~~~../lib/include/httpserver/details/http_endpoint.hpp:
128:9: warning: 'const' type qualifier on return type has no effect [-
Wignored-qualifiers] const bool is_regex_compiled() const
Clang complains about the const in front, gcc is okay with either one
removed.
Just pushed new code with const at the end
On Fri, 2020-08-07 at 22:01 -0700, Sebastiano Merlino wrote:
Got it. I think the real issue is the "const bool" (which makes no
sense).
Does using "bool is_regex_compiled() const" cause you any warning?
Effectively we want the method to be declared as not modifying the
object so I am not sure what the warning against that is.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
--
Chris Benesch <chris@beneschtech.com>
|
|
Thanks! |
…t and deferred_response, add OS specific readme for commonly seen issues
Issue or RFC Endorsed by Maintainers
None
Description of the Change
Updated some of the build scripts to be more portable and to build on FreeBSD.
Fixed a few compiler warnings
Added OS specific readmes for applicable issues to help users
Alternate Designs
Possible Drawbacks
Potentially break other platforms
Verification Process
Built on FreeBSD 12, Fedora 32, CentOS 7, and Mingw64 (Windows 10)
Release Notes
Added OS specific tips, and cleaned up some compiler warnings