★ wanayoo — archive 1999 https://github.com/ember-cli/ember-cli/pull/7937Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping default target browser for ie to ie11 #7937

Merged
merged 1 commit into from Aug 10, 2018
Merged

Conversation

arthirm
Copy link

@arthirm arthirm commented Jul 23, 2018

No description provided.

Copy link
Member

@rwjblue rwjblue left a comment

Looks good, can you also write a test that confirms config/targets.js of a newly generated application matches this fallback?

@rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 7, 2018

Updated test looks great, restarted CI to see if recent fixes on master fix the CI failures...

@@ -31,6 +31,7 @@ describe('Acceptance: ember new', function() {
}));

afterEach(function() {
delete process.env.CI;
Copy link
Member

@rwjblue rwjblue Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is causing the failures we are seeing in CI. Specifically because we rely on process.env.CI to be set so that we use the correct configuration for chrome (to avoid the setuid errors). See our default generated testem.js for how that works.

Can you tweak this to stash off the value and restore it instead? Something like:

let ORIGINAL_PROCESS_ENV_CI;
beforeEach(function() {
  // ...snip...
  ORIGINAL_PROCESS_ENV_CI = process.env.CI;
});

afterEach(function() {
  if (ORIGINAL_PROCESS_ENV_CI === undefined) {
    delete process.env.CI;
  } else {
    process.env.CI = ORIGINAL_PROCESS_ENV_CI;
  }
});

@rwjblue rwjblue merged commit 442ef4e into ember-cli:master Aug 10, 2018
2 of 3 checks passed
@rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 10, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants