Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadded ability to export array as raw data #2
Conversation
| @@ -265,3 +265,23 @@ func (bits *BitArray) ToArray() []int { | |||
|
|
|||
| return ints | |||
| } | |||
|
|
|||
| func (bits *BitArray) ToByteArray() []byte { | |||
| return bits.bytes | |||
damnever
Jul 18, 2019
Owner
I think Bytes() is more precise since there is no copy or conversion, and we need some doc comment to clarify that the changes to the bytes will affect the result of future operations from BitArray.
I think Bytes() is more precise since there is no copy or conversion, and we need some doc comment to clarify that the changes to the bytes will affect the result of future operations from BitArray.
| return nil, errors.New("data can't be nil") | ||
| } | ||
| lenpad := nwords(length) * _BytesPW | ||
| if len(data) != lenpad { |
damnever
Jul 18, 2019
Owner
I think we should create a new bytes slice with lenpad then copy content from the origin slice, also the length should be greater or equal to len(data).
I think we should create a new bytes slice with lenpad then copy content from the origin slice, also the length should be greater or equal to len(data).
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi, just needed something like this to persist bool arrays, but it lacked ability to export