★ wanayoo — archive 1999 https://github.com/blockstack/blockstack-browser/issues/288Nouvelle recherche | Portail wanayoo
Skip to content

/ blockstack-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update the portal codebase to trim out unnecessary utils replace them with the functions in Blockstack Auth #288

Closed
larrysalibra opened this issue Mar 7, 2017 · 2 comments
Closed

Chore: update the portal codebase to trim out unnecessary utils replace them with the functions in Blockstack Auth #288

larrysalibra opened this issue Mar 7, 2017 · 2 comments
Assignees
@larrysalibra
Labels
1 hour chore
Projects
Release v0.6.0 - Closed
Milestone
Release v0.6.0

Comments

@larrysalibra
Copy link
Member

@larrysalibra larrysalibra commented Mar 7, 2017

No description provided.

@larrysalibra larrysalibra created this issue from a note in Release v0.5.0 - Closed (To Do) Mar 7, 2017
@larrysalibra larrysalibra self-assigned this Mar 7, 2017
@larrysalibra larrysalibra added the v0.5.0 label Mar 7, 2017
@larrysalibra larrysalibra added this to the Release v0.5.0 milestone Mar 7, 2017
@guylepage3 guylepage3 mentioned this issue Mar 7, 2017
Closed
34 of 53 tasks complete
@shea256
Copy link
Member

@shea256 shea256 commented Mar 8, 2017

Writing some notes on this task...

In profile-utils.js we should be able to get rid of the following functions and replace them with their equivalents in blockstack.js:

  • verifyToken with verifyProfileToken
  • getProfileFromTokens with extractProfile

We can also get rid of verifyTokenRecord and just unpack the token records into tokens (verifyProfileToken(tokenRecords[0].token)).

We should also update signProfileForUpload so it uses the signProfileToken function in blockstack.js.

In profile-utils.js we should be able to get rid of the following functions and replace them with their equivalents in blockstack.js:

  • makeZoneFileForHostedProfile with makeProfileZoneFile
  • getTokenFileUrlFromZoneFile with getTokenFileUrl
@larrysalibra larrysalibra added v0.6.0 and removed v0.5.0 labels Mar 21, 2017
@guylepage3 guylepage3 mentioned this issue Mar 22, 2017
Closed
37 of 47 tasks complete
@shea256 shea256 removed the v0.6.0 label Mar 24, 2017
@larrysalibra larrysalibra moved this from To Do to Doing in Release v0.6.0 - Closed Mar 30, 2017
larrysalibra added a commit that referenced this issue Mar 30, 2017
@larrysalibra
remove blockstack-profiles, blockstack-proofs #288
Verified
This commit was signed with a verified signature.
larrysalibra Larry Salibra
GPG key ID: DE3B5425164C4849 Learn about signing commits
861fae7
larrysalibra added a commit that referenced this issue Mar 30, 2017
@larrysalibra
remove blockstack-zones #288
Verified
This commit was signed with a verified signature.
larrysalibra Larry Salibra
GPG key ID: DE3B5425164C4849 Learn about signing commits
9c59dd9
larrysalibra added a commit that referenced this issue Mar 30, 2017
@larrysalibra
remove blockstack-keychains #288
Verified
This commit was signed with a verified signature.
larrysalibra Larry Salibra
GPG key ID: DE3B5425164C4849 Learn about signing commits
ab2cbfa
larrysalibra added a commit that referenced this issue Mar 30, 2017
@larrysalibra
remove blockstack-auth #288
Verified
This commit was signed with a verified signature.
larrysalibra Larry Salibra
GPG key ID: DE3B5425164C4849 Learn about signing commits
60e1b61
@larrysalibra larrysalibra moved this from Doing to Done in Release v0.6.0 - Closed Mar 30, 2017
@larrysalibra
Copy link
Member Author

@larrysalibra larrysalibra commented Mar 30, 2017

Done.
larrysalibra added a commit that referenced this issue Mar 30, 2017
@larrysalibra
additional refactoring missed in #288
Verified
This commit was signed with a verified signature.
larrysalibra Larry Salibra
GPG key ID: DE3B5425164C4849 Learn about signing commits
2641064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larrysalibra larrysalibra

Labels
1 hour chore
Projects
Release v0.6.0 - Closed
Done
Milestone
Release v0.6.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@larrysalibra @shea256
You can’t perform that action at this time.