Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Add new 'powerShell/getCommandInformation' message #1185
Conversation
|
I think I'd want them in the same handler. Since they both return the same data. It'd be a smaller change too :) |
|
Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetCommandHandler.cs 1
See the complete overview on Codacy |
|
Duplicate of # |
| @@ -17,7 +17,10 @@ namespace Microsoft.PowerShell.EditorServices.Handlers | |||
| [Serial, Method("powerShell/getCommand")] | |||
BoryaBorya
Jun 23, 2020
Suggested change
[Serial, Method("powerShell/getCommand")]
[Serial, Method("powerShell/getCommand")]
Suggested change
| [Serial, Method("powerShell/getCommand")] | |
| [Serial, Method("powerShell/getCommand")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This adds a new getCommandInformation message used by the Command Explorer to get the details of a given command.
Pre-omnisharp we were optionally sending the name of a command in the
powerShell/getCommandmessage, and had code to get information for a single command in that instance. It appears this was removed.I am split on if it's better being separate handlers. On the one hand, it seems it might be easier to understand being separate handlers, but it adds code duplication that might not be needed.If kept as separate messages as shown here, there is some code cleanup we can do in the getCommand message handler as it's currently sending back values that are guaranteed to be empty and can be removed.