★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell-RFC/pull/193Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the `&` background operator (consistency with bash, richer functionality) #193

Open
wants to merge 9 commits into
base: master
from

Conversation

@KirkMunro
Copy link
Contributor

KirkMunro commented Jun 18, 2019

No description provided.

@KirkMunro KirkMunro changed the title first draft Improve the `&` background operator (consistency with bash, richer functionality) Jun 18, 2019
@dragonwolf83
Copy link

dragonwolf83 commented Jun 30, 2019

Ok, so my comments are in reverse order, lol. First time clicking "Review". Makes more sense if you read the last comment first.

Copy link
Member

joeyaiello left a comment

Trying to do more async reviews outside of Committee meetings, so that means my review here is not binding by any means. Just giving my (often naive) take.

Right now, I'm okay with $! and the new ProcessId property, but I have concerns about console overlays, as well as the change to --% (which I don't believe can be easily implemented, though I'd love to be proven wrong). I think we should document workarounds (inline in my comments) around the --% scenario.

1-Draft/RFCNNNN-Improve-Background-Operator.md Outdated Show resolved Hide resolved
1-Draft/RFCNNNN-Improve-Background-Operator.md Outdated Show resolved Hide resolved
1-Draft/RFCNNNN-Improve-Background-Operator.md Outdated Show resolved Hide resolved
@KirkMunro
Copy link
Contributor Author

KirkMunro commented Aug 2, 2019

Trying to do more async reviews outside of Committee meetings, so that means my review here is not binding by any means. Just giving my (often naive) take.

This is very much appreciated. Even just a non-binding "gut" take from you guys on these is very helpful, so I thank you for that.

KirkMunro added 2 commits Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.