★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8340Nouvelle recherche | Portail wanayoo
Skip to content

/PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build alpine tar.gz package in release builds #8340

Merged
merged 6 commits into from Nov 27, 2018

Conversation

Reviewers

@TravisEz13 TravisEz13

@daxian-dbw daxian-dbw

@SteveL-MSFT SteveL-MSFT

@anmenaga anmenaga

@PaulHigin PaulHigin

Assignees

@TravisEz13 TravisEz13

Labels
CL-BuildPackaging
Projects
None yet
Milestone
No milestone
2 participants
@adityapatwardhan @TravisEz13
@adityapatwardhan
Copy link
Member

commented Nov 27, 2018 •
edited

PR Summary

Enable building tar.gz package for Alpine in release builds.

PR Checklist

@adityapatwardhan adityapatwardhan requested a review from SteveL-MSFT Nov 27, 2018

@adityapatwardhan adityapatwardhan requested review from anmenaga, daxian-dbw, PaulHigin and TravisEz13 as code owners Nov 27, 2018

@adityapatwardhan adityapatwardhan assigned TravisEz13 Nov 27, 2018

@adityapatwardhan

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 27, 2018

@TravisEz13 I have validated the changes in a private build on VSTS.
@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 27, 2018

The preview docker file will also have to be updated.
@TravisEz13

TravisEz13 approved these changes Nov 27, 2018
View changes

@TravisEz13 TravisEz13 added the CL-BuildPackaging label Nov 27, 2018

@TravisEz13 TravisEz13 merged commit b0daa1e into PowerShell:master Nov 27, 2018
7 checks passed

7 checks passed

CodeFactor 49 issues fixed.
Details
PowerShell-CI-linux #PR-8340-20181127.01 succeeded
Details
PowerShell-CI-macos #PR-8340-20181127.01 succeeded
Details
PowerShell-CI-spelling #PR-8340-20181127.01 succeeded
Details
PowerShell-CI-windows #PR-8340-20181127.01 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
@adityapatwardhan

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 27, 2018

@TravisEz13 yes, working on the docker file.

@adityapatwardhan adityapatwardhan deleted the adityapatwardhan:BuildAlpine branch Nov 27, 2018

iSazonov added a commit to iSazonov/PowerShell that referenced this pull request Nov 29, 2018

@adityapatwardhan @iSazonov
Build Alpine `tar.gz` package in release builds (PowerShell#8340) 
Enable building tar.gz package for Alpine in release builds.

## PR Checklist

- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
    - Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Change is not breaking](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
    - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready.
- **User-facing changes**
    - [x] Not Applicable
    - **OR**
    - [ ] User-facing [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
        - [ ] Issue filed - Issue link:
- **Testing - New and feature**
    - [x] Not Applicable or can only be tested interactively
    - **OR**
    - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
        - [ ] [Add `[feature]` if the change is significant or affects feature tests](https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr)
fa391ba

adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this pull request Jan 11, 2019

@adityapatwardhan
Merged PR 6027: Build Alpine `tar.gz` package in release builds 
Build Alpine `tar.gz` package in release builds (PowerShell#8340)

Enable building tar.gz package for Alpine in release builds.

## PR Checklist

- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
    - Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Change is not breaking](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
    - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready.
- **User-facing changes**
    - [x] Not Applicable
    - **OR**
    - [ ] User-facing [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
        - [ ] Issue filed - Issue link:
- **Testing - New and feature**
    - [x] Not Applicable or can only be tested interactively
    - **OR**
    - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
        - [ ] [Add `[feature]` if the change is significant or affects feature tests](https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr)
c49b059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.