Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove `ShouldProcess` from Format-Hex #8178
Conversation
SteveL-MSFT
assigned
iSazonov
Nov 2, 2018
SteveL-MSFT
requested a review
from
iSazonov
Nov 2, 2018
SteveL-MSFT
requested review from
JamesWTruher and
PaulHigin
as
code owners
Nov 2, 2018
iSazonov
approved these changes
Nov 3, 2018
iSazonov
merged commit 7b243d5
into
PowerShell:master
Nov 6, 2018
7 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-8178-20181102.01 succeeded
Details
PowerShell-CI-macos
#PR-8178-20181102.01 succeeded
Details
PowerShell-CI-spelling
#PR-8178-20181102.01 succeeded
Details
PowerShell-CI-windows
#PR-8178-20181102.01 succeeded
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
license/cla
All CLA requirements met.
iSazonov
added
the
CL-General
label
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SteveL-MSFT commentedNov 2, 2018
•
edited
PR Summary
Format-hexdeclares support for ShouldProcess but doesn't actually implement it and it doesn't make sense for this passive cmdlet to implement ShouldProcess. Removed attribute so it doesn't show up in the syntax.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests