★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8166Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding verbose output for experimental implicit remoting batching feature #8166

Merged

Conversation

@PaulHigin
Copy link
Contributor

commented Nov 1, 2018

PR Summary

This change adds verbose output to the experimental implicit remoting batching feature, that provides information about whether the command line was batch-able for implicit remoting. If it is not batch-able then the reason why is provided. This is intended to help learn why a pipeline could not be batched and help address batching scenarios that should be covered.

Example:

$s = New-PSSession -host testVM -KeyFilePath -User paul
Invoke-Command $s { Import-PSSession 'c:\Modules\TestIMod\TestIMod.psd1' }
Import-PSSession $s -module TestIMod

$maxProcs = 1000
$filter = 'pwsh','powershell*'

$VerbosePreference = "Continue"

Get-AllProcesses -MaxCount $maxProcs | Select-Custom $filter | ForEach-Object { $_ }
VERBOSE: Implicit remoting command pipeline has been batched for execution on remote target.

NPM(K)    PM(M)      WS(M)     CPU(s)      Id  SI ProcessName
 ------    -----      -----     ------      --  -- -----------
     60   291.51     140.08     226.92   15184   2 powershell
     54   129.84     109.26     370.78   15832   2 powershell
     57    69.21      92.28      13.86     168   0 pwsh

100 | Get-AllProcesses -MaxCount $maxProcs | Select-Custom $filter | ForEach-Object { $_ }
VERBOSE: Command pipeline not supported for implicit remoting batching. : PipelineStartingWithExpressionNotSupported

NPM(K)    PM(M)      WS(M)     CPU(s)      Id  SI ProcessName
 ------    -----      -----     ------      --  -- -----------
     61   291.54     140.09     226.92   15184   2 powershell
     54   129.84     109.26     370.88   15832   2 powershell
     57    69.72      92.86      17.81     168   0 pwsh

PR Checklist

@PaulHigin

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2018

@SteveL-MSFT Can you review this change?

PaulHigin added some commits Nov 1, 2018

@SteveL-MSFT SteveL-MSFT removed this from the 6.1.x-servicing milestone Nov 1, 2018

@adityapatwardhan

This comment has been minimized.

Copy link
Member

commented Nov 5, 2018

The CI seems to be stuck. I will close and re-open the PR for restarting it.

@adityapatwardhan adityapatwardhan merged commit acf5eb5 into PowerShell:master Nov 5, 2018

7 checks passed

CodeFactor 2 issues fixed.
Details
PowerShell-CI-linux #PR-8166-20181105.01 succeeded
Details
PowerShell-CI-macos #PR-8166-20181105.01 succeeded
Details
PowerShell-CI-spelling #PR-8166-20181105.01 succeeded
Details
PowerShell-CI-windows #PR-8166-20181105.01 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@PaulHigin PaulHigin deleted the PaulHigin:UpdateImplicitRemotingBatching branch Nov 6, 2018

@iSazonov iSazonov added the CL-Engine label Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.