Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding verbose output for experimental implicit remoting batching feature #8166
+72
−28
Conversation
PaulHigin
requested review from
BrucePay and
daxian-dbw
as
code owners
Nov 1, 2018
PaulHigin
assigned
adityapatwardhan
Nov 1, 2018
PaulHigin
added
the
Experimental
label
Nov 1, 2018
PaulHigin
added this to the 6.1.x-servicing milestone
Nov 1, 2018
PaulHigin
removed
the
Experimental
label
Nov 1, 2018
This comment has been minimized.
This comment has been minimized.
|
@SteveL-MSFT Can you review this change? |
PaulHigin
added some commits
Nov 1, 2018
SteveL-MSFT
approved these changes
Nov 1, 2018
SteveL-MSFT
removed this from the 6.1.x-servicing milestone
Nov 1, 2018
PaulHigin
added some commits
Nov 2, 2018
This comment has been minimized.
This comment has been minimized.
|
The CI seems to be stuck. I will close and re-open the PR for restarting it. |
adityapatwardhan
closed this
Nov 5, 2018
adityapatwardhan
reopened this
Nov 5, 2018
adityapatwardhan
approved these changes
Nov 5, 2018
adityapatwardhan
merged commit acf5eb5
into
PowerShell:master
Nov 5, 2018
7 checks passed
CodeFactor
2 issues fixed.
Details
PowerShell-CI-linux
#PR-8166-20181105.01 succeeded
Details
PowerShell-CI-macos
#PR-8166-20181105.01 succeeded
Details
PowerShell-CI-spelling
#PR-8166-20181105.01 succeeded
Details
PowerShell-CI-windows
#PR-8166-20181105.01 succeeded
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
license/cla
All CLA requirements met.
Details
PaulHigin
deleted the
PaulHigin:UpdateImplicitRemotingBatching
branch
Nov 6, 2018
iSazonov
added
the
CL-Engine
label
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
PaulHigin commentedNov 1, 2018
PR Summary
This change adds verbose output to the experimental implicit remoting batching feature, that provides information about whether the command line was batch-able for implicit remoting. If it is not batch-able then the reason why is provided. This is intended to help learn why a pipeline could not be batched and help address batching scenarios that should be covered.
Example:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests