★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8108Nouvelle recherche | Portail wanayoo
Skip to content

/PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish test package at AGENT_WORKFOLDER if TEMP is not available #8108

Merged
merged 2 commits into from Oct 23, 2018
+7 −1

Conversation

Reviewers

@JamesWTruher JamesWTruher

@PaulHigin PaulHigin

@daxian-dbw daxian-dbw

@TravisEz13 TravisEz13

@anmenaga anmenaga

Assignees

@adityapatwardhan adityapatwardhan

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@adityapatwardhan @JamesWTruher @PaulHigin
@adityapatwardhan
Copy link
Member

commented Oct 23, 2018 •
edited

PR Summary

macOS hosted agents on Azure DevOps do not have $env:TEMP set. In that case, use $env:AGENT_WORKFOLDER

PR Checklist

@adityapatwardhan adityapatwardhan requested a review from JamesWTruher Oct 23, 2018

@adityapatwardhan adityapatwardhan requested review from anmenaga, daxian-dbw, PaulHigin and TravisEz13 as code owners Oct 23, 2018

@JamesWTruher

JamesWTruher reviewed Oct 23, 2018
View changes

Show resolved Hide resolved build.psm1
@JamesWTruher

JamesWTruher approved these changes Oct 23, 2018
View changes

Copy link
Member

left a comment

just one comment, and not a blocker in this case
@adityapatwardhan
Use rootFolder
Loading status checks…
33a27ad
@PaulHigin

PaulHigin approved these changes Oct 23, 2018
View changes

build.psm1
$rootFolder = $env:AGENT_WORKFOLDER
}

$packageRoot = Join-Path $rootFolder ('TestPackage-' + (new-guid))

This comment has been minimized.

Sign in to view
Copy link
@PaulHigin

PaulHigin Oct 23, 2018

Contributor

Is it possible to have both $env:Temp and $env:TF_BUILD be null? Maybe we should have a Test-Path here and throw an error message ... "package path cannot be found"?

This comment has been minimized.

Sign in to view
Copy link
@adityapatwardhan

adityapatwardhan Oct 23, 2018 •
edited

Author Member

$env:TEMP should be set in most cases. VSTS macOS hosts seem to be the only place where it is not set. $env:TF_BUILD is always set in VSTS builds. I will keep this as is for now. If we see problems we can address them.

@adityapatwardhan adityapatwardhan merged commit 05e9f78 into PowerShell:master Oct 23, 2018
8 checks passed

8 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-8108-20181023.02 succeeded
Details
PowerShell-CI-macos #PR-8108-20181023.02 succeeded
Details
PowerShell-CI-spelling #PR-8108-20181023.02 succeeded
Details
PowerShell-CI-windows #PR-8108-20181023.02 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.

@adityapatwardhan adityapatwardhan deleted the adityapatwardhan:TestPackageOnMacOs branch Oct 23, 2018

@iSazonov iSazonov assigned adityapatwardhan Oct 24, 2018

adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019

@adityapatwardhan
Publish test package at AGENT_WORKFOLDER if TEMP is not available (Po… 
…werShell#8108)
1034bf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.