★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8089Nouvelle recherche | Portail wanayoo
Skip to content

/PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Set-Location -LiteralPath to work with folders named "-" and "+" #8089

Merged
merged 4 commits into from Oct 24, 2018
+113 −47

Conversation

Reviewers

@bergmeister bergmeister

@anmenaga anmenaga

@iSazonov iSazonov

@daxian-dbw daxian-dbw

@BrucePay BrucePay

@adityapatwardhan adityapatwardhan

Assignees

@iSazonov iSazonov

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@SteveL-MSFT @bergmeister @anmenaga @iSazonov
@SteveL-MSFT
Copy link
Member

commented Oct 20, 2018 •
edited

PR Summary

#7206 added the ability to use cd - and cd + to navigate through location history. However, it prevented navigating to folders literally named "-" and "+". The internal setlocation() api doesn't differentiate literal and non-literal paths so fix is to overload it with a flag to indicate path is literal so it doesn't process "-" and "+" as shortcuts.

Fix #8086

PR Checklist

@SteveL-MSFT SteveL-MSFT assigned iSazonov Oct 20, 2018

@SteveL-MSFT SteveL-MSFT requested review from BrucePay and anmenaga Oct 20, 2018

@SteveL-MSFT SteveL-MSFT requested review from adityapatwardhan and daxian-dbw as code owners Oct 20, 2018

@bergmeister

bergmeister approved these changes Oct 20, 2018
View changes

Copy link
Contributor

left a comment

LGTM, thanks for quickly taking on this task.
@iSazonov

iSazonov reviewed Oct 20, 2018
View changes

Show resolved Hide resolved src/System.Management.Automation/engine/SessionStateLocationAPIs.cs Outdated
Show resolved Hide resolved src/System.Management.Automation/engine/SessionStateLocationAPIs.cs Outdated
Show resolved Hide resolved src/System.Management.Automation/engine/SessionStateLocationAPIs.cs Outdated
Show resolved Hide resolved src/System.Management.Automation/engine/SessionStateLocationAPIs.cs

iSazonov and others added some commits Oct 21, 2018

@iSazonov @SteveL-MSFT
Update src/System.Management.Automation/engine/SessionStateLocationAP… 
…Is.cs

Co-Authored-By: SteveL-MSFT <slee@microsoft.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
139600a
@iSazonov @SteveL-MSFT
Update src/System.Management.Automation/engine/SessionStateLocationAP… 
…Is.cs

Co-Authored-By: SteveL-MSFT <slee@microsoft.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3361fe0
@iSazonov

iSazonov reviewed Oct 21, 2018
View changes

test/powershell/Modules/Microsoft.PowerShell.Management/Set-Location.Tests.ps1
Set-Location $TestDrive
$literalPath = Join-Path $TestDrive $path
New-Item -ItemType Directory -Path $literalPath
Set-Location -LiteralPath $path

This comment has been minimized.

Sign in to view
Copy link
@iSazonov

iSazonov Oct 21, 2018

Collaborator

Not for the PR. Should this work too?

Set-Location -Path `+

This comment has been minimized.

Sign in to view
Copy link
@SteveL-MSFT

SteveL-MSFT Oct 22, 2018

Author Member

Escaping happens outside of this PR and this will continue to work
@iSazonov

iSazonov approved these changes Oct 21, 2018
View changes

@anmenaga

anmenaga approved these changes Oct 23, 2018
View changes

Copy link
Contributor

left a comment

It would be good to have a [feature] test pass for this.
@SteveL-MSFT
[feature] 
address codefactor issues
Loading status checks…
39165c8

@SteveL-MSFT SteveL-MSFT force-pushed the SteveL-MSFT:set-location-literalpath branch to 39165c8 Oct 23, 2018

@iSazonov iSazonov merged commit 9141b11 into PowerShell:master Oct 24, 2018
8 checks passed

8 checks passed

CodeFactor 46 issues fixed. 3 issues found.
Details
PowerShell-CI-linux #PR-8089-20181023.01 succeeded
Details
PowerShell-CI-macos #PR-8089-20181023.01 succeeded
Details
PowerShell-CI-spelling #PR-8089-20181023.01 succeeded
Details
PowerShell-CI-windows #PR-8089-20181023.01 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@iSazonov iSazonov changed the title enable set-location -literalpath to work with folders named "-" and "+" Enable Set-Location -LiteralPath to work with folders named "-" and "+" Oct 24, 2018

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019

@SteveL-MSFT @iSazonov
Enable Set-Location -LiteralPath to work with folders named "-" and "… 
…+" (PowerShell#8089)
899630e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.