★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8084Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added updated photo of VScode due to new version of VScode #8084

Merged
merged 12 commits into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@lassehastrup
Copy link
Contributor

commented Oct 19, 2018

PR Summary

PR Checklist

lassehastrup added some commits Oct 19, 2018

@anmenaga
Copy link
Contributor

left a comment

New photo was taken on a high-res screen, so when auto-scaled to the low-width boundaries of 'using-vscode.md' tutorial it will be unreadable.
For taking the screenshot please: 1) temporary drop the resolution of the screen 2) make sure that VS code window is relatively square (currently proposed image is twice as wide as it is tall).

PS. While you are at it, it would be great if you could double-check 'Editing with Visual Studio Code' instructions on 'using-vscode.md'. Are they still accurate on the latest VS Code version? Thanks.

lassehastrup added some commits Oct 23, 2018

@lassehastrup

This comment has been minimized.

Copy link
Contributor Author

commented Oct 23, 2018

@TravisEz13 TravisEz13 merged commit 7076d80 into PowerShell:master Oct 29, 2018

8 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-8084-20181023.08 succeeded
Details
PowerShell-CI-macos #PR-8084-20181023.08 succeeded
Details
PowerShell-CI-spelling #PR-8084-20181023.08 succeeded
Details
PowerShell-CI-windows #PR-8084-20181023.08 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.