★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8016Nouvelle recherche | Portail wanayoo
Skip to content

/PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux ARM64 build support #8016

Merged
merged 3 commits into from Dec 5, 2018
+33 −9

Conversation

Reviewers

@adityapatwardhan adityapatwardhan

@anmenaga anmenaga

@daxian-dbw daxian-dbw

@TravisEz13 TravisEz13

Assignees

@adityapatwardhan adityapatwardhan

Labels
Area-Build CL-BuildPackaging
Projects
None yet
Milestone
No milestone
6 participants
@slide @TravisEz13 @iSazonov @SteveL-MSFT @adityapatwardhan @joeyaiello
@slide
Copy link
Contributor

commented Oct 12, 2018

PR Summary

This adds an additional flag to allow building for linux-arm64.

PR Checklist

  • [PR has a meaningful title]
  • [Summarized changes]
  • [Change is not breaking]
  • [Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header]
  • This PR is ready to merge and is not [Work in Progress]
  • User-facing changes
    • Not Applicable
  • Testing - New and feature
    • Not Applicable or can only be tested interactively

@slide slide requested review from adityapatwardhan, anmenaga, daxian-dbw and TravisEz13 as code owners Oct 12, 2018

@slide slide referenced this pull request Oct 12, 2018

Closed

Request for PowerShell for ARM64 Ubuntu #7330

@slide

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 12, 2018

Related to #7330

@TravisEz13 TravisEz13 added Area-Build Documentation Needed labels Oct 12, 2018

@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 12, 2018

@slide Did you do any testing of the build?
@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 12, 2018

Is ARM64 also Raspbian? Should we update this doc to say both architectures of Raspbian?
https://docs.microsoft.com/en-us/powershell/scripting/powershell-core-support?view=powershell-6
@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 12, 2018 •
edited

You also need to do some work if you want us to release a package (you could just file an issue for this, if that wasn't your intent.)

The packaging module needs to be updated to be able to package TarArm64

PowerShell/tools/packaging/packaging.psm1

Line 68 in 81b67c9

} elseif ($Type -eq "tar-arm") {

PowerShell/tools/releaseBuild/Images/GenericLinuxFiles/PowerShellPackage.ps1

Line 57 in 81b67c9

if ($TarArm) {

Needs to be updated with a TarArm64 option

And it needs to be called here:

PowerShell/tools/releaseBuild/build.json

Line 264 in 81b67c9

"BuildCommand": "/PowerShellPackage.ps1 -location _RepoDestinationPath_ -destination _DockerVolume_ -ReleaseTag _ReleaseTag_ -TarX64 -TarArm",

@slide

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 13, 2018

Yes, I tested on my RockPro64 board. I was using it to build ironpython on that board. I will also update the packaging, I was looking for that and didn't know where it was.
@slide

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 13, 2018

My board is running Ubuntu 18.04 Bionic, not Raspian.
@slide

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 13, 2018

How do I run the packaging stuff locally to test it out?
@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 13, 2018 •
edited

run start-psbuild -configuration 'release' -crossgen -psmodulerestore
then import the packaging module Import-module .\tools\packaging -force
then run packaging start-pspackaging -Type tar-arm64

I did this from memory and start-pspackaging might tell you, that you need to skip release checks... It's fine to do that for development.

If you only change the packaging code, you can just re-import the packaging module, and rerun the packaging step (this is why I separated the modules.)

@joeyaiello joeyaiello referenced this pull request Oct 15, 2018

Closed

Docs needed for 'Add Linux ARM64 build support' #3016

@joeyaiello joeyaiello removed Documentation Needed labels Oct 15, 2018

@iSazonov

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Nov 1, 2018

@slide What is status of the PR? Do you want to continue?
@slide

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Nov 1, 2018

Yes, I do, I just need to get back to it again. I'll try and do it this next week.

@slide slide requested a review from PaulHigin as a code owner Nov 8, 2018

@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 13, 2018

restarted linux CI due to a connectivity issue
@slide

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Nov 13, 2018

I do still plan on getting back to this, if it needs to be closed for now for some reason, I can reopen at a later date if desired.
@slide

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Dec 3, 2018

I will not have time to get back to this for some time. Trying to get a local build of the package stuff has not been easy.

@slide slide closed this Dec 3, 2018

@SteveL-MSFT

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 4, 2018

@slide Thanks for starting this, I'll submit a new PR with the packaging work along with the changes you've made for the build

@SteveL-MSFT SteveL-MSFT reopened this Dec 4, 2018

@SteveL-MSFT

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 4, 2018

I'll just re-use this PR

@slide slide requested review from BrucePay and Francisco-Gamino as code owners Dec 4, 2018

@slide slide requested review from JamesWTruher, joeyaiello and mirichmo as code owners Dec 4, 2018

@SteveL-MSFT SteveL-MSFT assigned adityapatwardhan Dec 4, 2018

@SteveL-MSFT SteveL-MSFT removed request for joeyaiello, BrucePay, JamesWTruher, Francisco-Gamino, mirichmo and PaulHigin Dec 4, 2018

@SteveL-MSFT SteveL-MSFT added the CL-BuildPackaging label Dec 4, 2018

@SteveL-MSFT
[package] 
update packaging to support tar-arm64
Loading status checks…
d22bd92
@adityapatwardhan

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 4, 2018

@SteveL-MSFT - You need to add items suggest by comment #8016 (comment)
@SteveL-MSFT
[package] 
address Travis' feedback
Loading status checks…
5c05b80
@SteveL-MSFT

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 4, 2018

@adityapatwardhan latest commit should address the rest of @TravisEz13 's feedback
@adityapatwardhan

adityapatwardhan approved these changes Dec 4, 2018
View changes

@adityapatwardhan adityapatwardhan merged commit 74de391 into PowerShell:master Dec 5, 2018
6 checks passed

6 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-8016-20181204.03 succeeded
Details
PowerShell-CI-macos #PR-8016-20181204.03 succeeded
Details
PowerShell-CI-spelling #PR-8016-20181204.03 succeeded
Details
PowerShell-CI-windows #PR-8016-20181204.03 succeeded
Details
license/cla All CLA requirements met.
Details
@adityapatwardhan

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 5, 2018

@slide Thank you for your contribution!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.