★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/7948Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cURL to the Bash users list in README.md #7948

Merged
merged 2 commits into from Oct 9, 2018

Conversation

Projects
None yet
4 participants
@vmsilvamolina
Copy link
Contributor

commented Oct 5, 2018

PR Summary

add the cURL example on the Bash users list

PR Checklist

@@ -100,7 +100,7 @@ Note that all bash commands should continue working on PowerShell session.
| rm -r <folderName> |Remove-Item <folderName> -Recurse |Delete a folder
| find -name build* |Get-ChildItem build* -Recurse |Find a file or folder starting with 'build'
| grep -Rin "sometext" --include="*.cs" |Get-ChildItem -Recurse -Filter *.cs <br> \| Select-String -Pattern "sometext" | Recursively case-insensitive search for text in files

| curl dominio.com | Invoke-WebRequest dominio.com | Transfer data from or to a web from differentes protocols

This comment has been minimized.

Copy link
@iSazonov

iSazonov Oct 6, 2018

Collaborator

Maybe Transfer data from web?

This comment has been minimized.

Copy link
@SteveL-MSFT

SteveL-MSFT Oct 6, 2018

Member

I think Invoke-RestMethod is more similar to curl than Invoke-WebRequest. Also, the example does work with curl and it's better to use a more generic URL:

curl https://github.com
Invoke-RestMethod https://github.com

For the description, maybe: Transfer data to or from the web

This comment has been minimized.

Copy link
@vmsilvamolina

vmsilvamolina Oct 8, 2018

Author Contributor

Ok, I'll make the changes.

@iSazonov iSazonov requested review from SteveL-MSFT and TravisEz13 Oct 6, 2018

@@ -100,7 +100,7 @@ Note that all bash commands should continue working on PowerShell session.
| rm -r &lt;folderName> |Remove-Item &lt;folderName> -Recurse |Delete a folder
| find -name build* |Get-ChildItem build* -Recurse |Find a file or folder starting with 'build'
| grep -Rin "sometext" --include="*.cs" |Get-ChildItem -Recurse -Filter *.cs <br> \| Select-String -Pattern "sometext" | Recursively case-insensitive search for text in files

| curl dominio.com | Invoke-WebRequest dominio.com | Transfer data from or to a web from differentes protocols

This comment has been minimized.

Copy link
@SteveL-MSFT

SteveL-MSFT Oct 6, 2018

Member

I think Invoke-RestMethod is more similar to curl than Invoke-WebRequest. Also, the example does work with curl and it's better to use a more generic URL:

curl https://github.com
Invoke-RestMethod https://github.com

For the description, maybe: Transfer data to or from the web

@SteveL-MSFT
Copy link
Member

left a comment

LGTM

@iSazonov iSazonov merged commit e29b5ee into PowerShell:master Oct 9, 2018

8 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-7948-20181008.01 succeeded
Details
PowerShell-CI-macos #PR-7948-20181008.01 succeeded
Details
PowerShell-CI-spelling #PR-7948-20181008.01 succeeded
Details
PowerShell-CI-windows #PR-7948-20181008.01 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.

@iSazonov iSazonov changed the title add cURL to the Bash users list Add cURL to the Bash users list in README.md Oct 9, 2018

@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2018

@vmsilvamolina Thanks for your contribution!

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.