Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd cURL to the Bash users list in README.md #7948
Conversation
iSazonov
reviewed
Oct 6, 2018
docs/learning-powershell/README.md
Outdated
| @@ -100,7 +100,7 @@ Note that all bash commands should continue working on PowerShell session. | |||
| | rm -r <folderName> |Remove-Item <folderName> -Recurse |Delete a folder | |||
| | find -name build* |Get-ChildItem build* -Recurse |Find a file or folder starting with 'build' | |||
| | grep -Rin "sometext" --include="*.cs" |Get-ChildItem -Recurse -Filter *.cs <br> \| Select-String -Pattern "sometext" | Recursively case-insensitive search for text in files | |||
|
|
|||
| | curl dominio.com | Invoke-WebRequest dominio.com | Transfer data from or to a web from differentes protocols | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SteveL-MSFT
Oct 6, 2018
Member
I think Invoke-RestMethod is more similar to curl than Invoke-WebRequest. Also, the example does work with curl and it's better to use a more generic URL:
curl https://github.com
Invoke-RestMethod https://github.com
For the description, maybe: Transfer data to or from the web
This comment has been minimized.
This comment has been minimized.
iSazonov
requested review from
SteveL-MSFT and
TravisEz13
Oct 6, 2018
SteveL-MSFT
requested changes
Oct 6, 2018
docs/learning-powershell/README.md
Outdated
| @@ -100,7 +100,7 @@ Note that all bash commands should continue working on PowerShell session. | |||
| | rm -r <folderName> |Remove-Item <folderName> -Recurse |Delete a folder | |||
| | find -name build* |Get-ChildItem build* -Recurse |Find a file or folder starting with 'build' | |||
| | grep -Rin "sometext" --include="*.cs" |Get-ChildItem -Recurse -Filter *.cs <br> \| Select-String -Pattern "sometext" | Recursively case-insensitive search for text in files | |||
|
|
|||
| | curl dominio.com | Invoke-WebRequest dominio.com | Transfer data from or to a web from differentes protocols | |||
This comment has been minimized.
This comment has been minimized.
SteveL-MSFT
Oct 6, 2018
Member
I think Invoke-RestMethod is more similar to curl than Invoke-WebRequest. Also, the example does work with curl and it's better to use a more generic URL:
curl https://github.com
Invoke-RestMethod https://github.com
For the description, maybe: Transfer data to or from the web
SteveL-MSFT
assigned
iSazonov
Oct 8, 2018
TravisEz13
approved these changes
Oct 8, 2018
iSazonov
merged commit e29b5ee
into
PowerShell:master
Oct 9, 2018
8 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-7948-20181008.01 succeeded
Details
PowerShell-CI-macos
#PR-7948-20181008.01 succeeded
Details
PowerShell-CI-spelling
#PR-7948-20181008.01 succeeded
Details
PowerShell-CI-windows
#PR-7948-20181008.01 succeeded
Details
WIP
ready for review
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
license/cla
All CLA requirements met.
iSazonov
changed the title
add cURL to the Bash users list
Add cURL to the Bash users list in README.md
Oct 9, 2018
This comment has been minimized.
This comment has been minimized.
|
@vmsilvamolina Thanks for your contribution! |
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vmsilvamolina commentedOct 5, 2018
•
edited by iSazonov
PR Summary
add the cURL example on the Bash users list
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests