★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/7932Nouvelle recherche | Portail wanayoo
Skip to content

/PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify verb for context menu to avoid overriding the default verb #7932

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Reviewers

@SteveL-MSFT SteveL-MSFT

@TravisEz13 TravisEz13

@TravisEz13 TravisEz13

Assignees

@TravisEz13 TravisEz13

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@bergmeister @iSazonov @SteveL-MSFT @TravisEz13
@bergmeister
Copy link
Contributor

commented Oct 3, 2018 •
edited

PR Summary

Fix is to specify the verb (pwsh) for the context menu, otherwise there can be special cases (see issues) where it overrides the default verb, see comment here for details. Thanks to @GeeLaw for the helpful comments.

I will manually check in the next days that the installer will remove the old open entries during upgrade.

PR Checklist
@iSazonov

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Oct 3, 2018

If we update current "broken" installation with the new installer what will happen to the old "open" key? I'd expect that we remove it.

@iSazonov iSazonov requested review from TravisEz13 and SteveL-MSFT Oct 3, 2018

@iSazonov iSazonov assigned TravisEz13 Oct 3, 2018

@bergmeister

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 3, 2018 •
edited

During an upgrade, old components get removed, therefore the old registry keys 'should' get removed.
As mentioned in the description, I will manually test this by creating a 6.1.0, 6.1.1 and 6.2.0 installer and go through the upgrade scenarios to be sure since WiX/MSI is known to have unintuitive behaviour.
@SteveL-MSFT

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 3, 2018

@bergmeister the change looks fine, but will wait for your testing results
@bergmeister

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 3, 2018 •
edited

@SteveL-MSFT @iSazonov
I manually created installers for 6.1.0, 6.1.1 and 6.2.0 and can confirm that the old open registry keys get replaced with the openpwsh keys upon upgrade from 6.1.0 to 6.1.1 and from 6.1.0 to 6.2.0 and the keys also get removed on uninstall.
I created the MSIs as follows:

Import-Module .\build.psm1; Start-PSBuild -Clean -CrossGen -PSModuleRestore -Runtime win7-x64 -Configuration Release; Import-Module .\tools\packaging
Start-PSPackage -Type msi -WindowsRuntime 'win7-x64' -SkipReleaseChecks -Version 6.1.0 # from master
Start-PSPackage -Type msi -WindowsRuntime 'win7-x64' -SkipReleaseChecks -Version 6.1.1 # from PR branch
Start-PSPackage -Type msi -WindowsRuntime 'win7-x64' -SkipReleaseChecks -Version 6.2.0 # from PR branch
@SteveL-MSFT

SteveL-MSFT approved these changes Oct 3, 2018
View changes

@TravisEz13 TravisEz13 merged commit 49826a7 into PowerShell:master Oct 4, 2018
8 checks passed

8 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-7932-20181003.01 succeeded
Details
PowerShell-CI-macos #PR-7932-20181003.01 succeeded
Details
PowerShell-CI-spelling #PR-7932-20181003.01 succeeded
Details
PowerShell-CI-windows #PR-7932-20181003.01 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.

@bergmeister bergmeister referenced this pull request Oct 12, 2018

Closed

Windows Previous Versions 'Open' of previous version of folder causes open of PowerShell at that location and point in time. #8007

@bergmeister bergmeister referenced this pull request Nov 17, 2018

Closed

PowerShell-6.2.0-preview.2-win-x64 creates duplicate "Open here" context menu item (also preview.3) #8290

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019

@bergmeister @TravisEz13
Specify verb, `pwsh`, for shell context menu to avoid overriding the … 
…default verb (PowerShell#7932)
2fd323b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.