★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/7883Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `Enter-PSSession -ContainerId` for newest Windows #7883

Merged
merged 4 commits into from Oct 9, 2018

Conversation

Projects
None yet
4 participants
@SteveL-MSFT
Copy link
Member

commented Sep 27, 2018

PR Summary

The code tries to retrieve the runtimeid of the container, but Hyper-V team changed the type name (namespace) and from a property to a field. To support older Windows, we first check for the new type and then fallback to checking for the old type.

Fix #5794

PR Checklist

Steve Lee (POWERSHELL)
Hyper-V team changed the type used to get the runtimeid, so need to c…
…heck for new type and fall back to old type

@SteveL-MSFT SteveL-MSFT requested a review from PaulHigin Sep 27, 2018

@SteveL-MSFT SteveL-MSFT requested a review from mirichmo as a code owner Sep 27, 2018

Steve Lee (POWERSHELL)
Steve Lee (POWERSHELL)

@SteveL-MSFT SteveL-MSFT force-pushed the SteveL-MSFT:enter-pssession-container branch to db88f4b Oct 3, 2018

@PaulHigin
Copy link
Contributor

left a comment

LGTM

Steve Lee (POWERSHELL)

@daxian-dbw daxian-dbw merged commit 339abe0 into PowerShell:master Oct 9, 2018

8 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-7883-20181009.01 succeeded
Details
PowerShell-CI-macos #PR-7883-20181009.01 succeeded
Details
PowerShell-CI-spelling #PR-7883-20181009.01 succeeded
Details
PowerShell-CI-windows #PR-7883-20181009.01 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@SteveL-MSFT SteveL-MSFT deleted the SteveL-MSFT:enter-pssession-container branch Oct 9, 2018

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019

Fix `Enter-PSSession -ContainerId` for the latest Windows (PowerShell…
…#7883)

Hyper-V team changed the type used to get the `runtimeid`. We need to check for new type and fall back to old type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.