Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix `Enter-PSSession -ContainerId` for newest Windows #7883
+39
−5
Conversation
SteveL-MSFT
assigned
daxian-dbw
Sep 27, 2018
SteveL-MSFT
requested a review
from
PaulHigin
Sep 27, 2018
SteveL-MSFT
requested a review
from
mirichmo
as a
code owner
Sep 27, 2018
SteveL-MSFT
force-pushed the
SteveL-MSFT:enter-pssession-container
branch
to
db88f4b
Oct 3, 2018
daxian-dbw
approved these changes
Oct 9, 2018
daxian-dbw
merged commit 339abe0
into
PowerShell:master
Oct 9, 2018
8 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-7883-20181009.01 succeeded
Details
PowerShell-CI-macos
#PR-7883-20181009.01 succeeded
Details
PowerShell-CI-spelling
#PR-7883-20181009.01 succeeded
Details
PowerShell-CI-windows
#PR-7883-20181009.01 succeeded
Details
WIP
ready for review
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
license/cla
All CLA requirements met.
Details
SteveL-MSFT
deleted the
SteveL-MSFT:enter-pssession-container
branch
Oct 9, 2018
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SteveL-MSFT commentedSep 27, 2018
•
edited
PR Summary
The code tries to retrieve the runtimeid of the container, but Hyper-V team changed the type name (namespace) and from a property to a field. To support older Windows, we first check for the new type and then fallback to checking for the old type.
Fix #5794
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests