★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/7850Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'TimeToLive' and 'Hops' aliases to MaxHops parameter of Test-Connection cmdlet. #7850

Merged
merged 7 commits into from Sep 27, 2018

Conversation

Projects
None yet
5 participants
@sethvs
Copy link
Contributor

commented Sep 23, 2018

PR Summary

Fix #7849

Add the following aliases to MaxHops parameter of Test-Connection cmdlet:

TimeToLive
It is the similar parameter's name from Windows PowerShell Test-Connection cmdlet .

Hops
Similar parameter's name from Test-NetConnection cmdlet.

Fix MaxHops parameter summary.

PR Checklist

@sethvs

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2018

Hm. I haven't touched NJsonSchema.

@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2018

@sethvs Please update NJsonSchema package version. It is not related to the PR but it come from our new common test.

@iSazonov iSazonov requested a review from SteveL-MSFT Sep 26, 2018

@iSazonov iSazonov self-assigned this Sep 26, 2018

@sethvs sethvs requested review from anmenaga and TravisEz13 as code owners Sep 26, 2018

@sethvs

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2018

Should I update Markdig.Signed Version?

@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2018

Feel free to update.

@SteveL-MSFT

This comment has been minimized.

Copy link
Member

commented Sep 26, 2018

@sethvs instead of updating the ref versions, you should just rebase against upstream master which has those fixed

@anmenaga

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2018

@adityapatwardhan is it something that requires "User-facing Documentation needed"
or alternative aliases will be automatically included in the help?

@sethvs sethvs requested a review from BrucePay as a code owner Sep 26, 2018

@sethvs

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2018

@SteveL-MSFT Rebased.

@sethvs

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2018

@anmenaga The help for PowerShell Core 6.1 Test-Connection now is almost similar to Windows PowerShell 5.1 Test-Connection. It should be massively reworked.

@adityapatwardhan

This comment has been minimized.

Copy link
Member

commented Sep 26, 2018

@anmenaga Yes, we need to file an issue according to the template for updating the docs.

@sethvs

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2018

@anmenaga @adityapatwardhan Created issue and PR in powershell-Docs repo.

@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Sep 27, 2018

@sethvs The PR still contains other's commits. Please rebase properly.

sethvs added some commits Sep 23, 2018

@sethvs sethvs force-pushed the sethvs:testConnection branch to 074e263 Sep 27, 2018

@sethvs

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2018

@iSazonov Done.

@iSazonov iSazonov merged commit 2291a89 into PowerShell:master Sep 27, 2018

8 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-7850-20180927.03 succeeded
Details
PowerShell-CI-macos #PR-7850-20180927.03 succeeded
Details
PowerShell-CI-spelling #PR-7850-20180927.03 succeeded
Details
PowerShell-CI-windows #PR-7850-20180927.03 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@sethvs sethvs deleted the sethvs:testConnection branch Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.