Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd 'TimeToLive' and 'Hops' aliases to MaxHops parameter of Test-Connection cmdlet. #7850
Conversation
sethvs
requested review from
adityapatwardhan and
daxian-dbw
as
code owners
Sep 23, 2018
This comment has been minimized.
This comment has been minimized.
|
Hm. I haven't touched NJsonSchema. |
adityapatwardhan
approved these changes
Sep 24, 2018
This comment has been minimized.
This comment has been minimized.
|
@sethvs Please update NJsonSchema package version. It is not related to the PR but it come from our new common test. |
iSazonov
requested a review
from
SteveL-MSFT
Sep 26, 2018
iSazonov
self-assigned this
Sep 26, 2018
sethvs
requested review from
anmenaga and
TravisEz13
as
code owners
Sep 26, 2018
This comment has been minimized.
This comment has been minimized.
|
Should I update Markdig.Signed Version? |
This comment has been minimized.
This comment has been minimized.
|
Feel free to update. |
This comment has been minimized.
This comment has been minimized.
|
@sethvs instead of updating the ref versions, you should just rebase against upstream master which has those fixed |
This comment has been minimized.
This comment has been minimized.
|
@adityapatwardhan is it something that requires "User-facing Documentation needed" |
sethvs
requested a review
from
BrucePay
as a
code owner
Sep 26, 2018
This comment has been minimized.
This comment has been minimized.
|
@SteveL-MSFT Rebased. |
This comment has been minimized.
This comment has been minimized.
|
@anmenaga The help for PowerShell Core 6.1 |
This comment has been minimized.
This comment has been minimized.
|
@anmenaga Yes, we need to file an issue according to the template for updating the docs. |
This comment has been minimized.
This comment has been minimized.
|
@anmenaga @adityapatwardhan Created issue and PR in powershell-Docs repo. |
This comment has been minimized.
This comment has been minimized.
|
@sethvs The PR still contains other's commits. Please rebase properly. |
sethvs
added some commits
Sep 23, 2018
sethvs
force-pushed the
sethvs:testConnection
branch
to
074e263
Sep 27, 2018
This comment has been minimized.
This comment has been minimized.
|
@iSazonov Done. |
sethvs commentedSep 23, 2018
•
edited
PR Summary
Fix #7849
Add the following aliases to MaxHops parameter of
Test-Connectioncmdlet:TimeToLive
It is the similar parameter's name from Windows PowerShell
Test-Connectioncmdlet .Hops
Similar parameter's name from
Test-NetConnectioncmdlet.Fix MaxHops parameter summary.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests