★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/7830Nouvelle recherche | Portail wanayoo
Skip to content

/PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fxdependent PS package tests #7830

Merged
merged 3 commits into from Oct 18, 2018
+384 −5

Conversation

Reviewers

@TravisEz13 TravisEz13

@adityapatwardhan adityapatwardhan

@daxian-dbw daxian-dbw

Assignees

@adityapatwardhan adityapatwardhan

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@anmenaga @adityapatwardhan @TravisEz13
@anmenaga
Copy link
Contributor

commented Sep 20, 2018

PR Summary

Fix #7750

fxdependent package = .NET framework dependent PowerShell package.
It is is a small-footprint (~22 MB) PowerShell package that can be run on a machine where dotnet runtime is installed separately. Requirement for having such package is driven by .NET team.

This PR adds release-time tests for fxdependent package for all currently supported Linux configurations.

PR Checklist
Andrew Menagarishvili
fxdependent pacakge tests
Loading status checks…
d03354d

@anmenaga anmenaga assigned adityapatwardhan Sep 20, 2018

@anmenaga anmenaga requested review from TravisEz13 and adityapatwardhan Sep 20, 2018

@anmenaga anmenaga requested a review from daxian-dbw as a code owner Sep 20, 2018

@TravisEz13

TravisEz13 reviewed Sep 20, 2018
View changes

docker/tests/Templates/fxdependent-centos7/Dockerfile Outdated

# Download and run tests
RUN $TESTDOWNLOADCOMMAND
RUN dotnet /opt/microsoft/powershell/pwsh.dll -c "Import-Module /PowerShell/build.psm1;\$dir='/usr/local/share/powershell/Modules';\$null=New-Item -Type Directory -Path \$dir -ErrorAction SilentlyContinue;Restore-PSPester -Destination \$dir;exit (Invoke-Pester $TESTLIST -PassThru).FailedCount"

This comment has been minimized.

Sign in to view
Copy link
@TravisEz13

TravisEz13 Sep 20, 2018

Member

missing newline at end of the file

This comment has been minimized.

Sign in to view
Copy link
@anmenaga

anmenaga Sep 26, 2018

Author Contributor

fixed.
@TravisEz13

TravisEz13 requested changes Sep 20, 2018
View changes

docker/tests/Templates/fxdependent-centos7/Dockerfile
@@ -0,0 +1,32 @@
FROM centos:7

This comment has been minimized.

Sign in to view
Copy link
@TravisEz13

TravisEz13 Sep 20, 2018

Member

We should base this off the 2.1-runtime and 2.1-sdk image flavors from https://hub.docker.com/r/microsoft/dotnet/tags/

This comment has been minimized.

Sign in to view
Copy link
@anmenaga

anmenaga Sep 26, 2018

Author Contributor

Updated this for ubuntu18.04 and debian.9;
Unfortunately they don't have any other images.

This comment has been minimized.

Sign in to view
Copy link
@TravisEz13

TravisEz13 Oct 1, 2018

Member

Do we need to test all these platforms?
docker/tests/Templates/fxdependent-debian.8/Dockerfile
apt-transport-https \
locales \
git \
wget

This comment has been minimized.

Sign in to view
Copy link
@TravisEz13

TravisEz13 Sep 20, 2018

Member

don't add wget, use the docker ADD commande

This comment has been minimized.

Sign in to view
Copy link
@anmenaga

anmenaga Sep 26, 2018

Author Contributor

updated.
docker/tests/Templates/fxdependent-centos7/Dockerfile Outdated

# Install dependencies
RUN yum install -y \
curl \

This comment has been minimized.

Sign in to view
Copy link
@TravisEz13

TravisEz13 Sep 20, 2018

Member

Don't add curl, see comments about wget

This comment has been minimized.

Sign in to view
Copy link
@anmenaga

anmenaga Sep 26, 2018

Author Contributor

updated.
@adityapatwardhan

adityapatwardhan requested changes Sep 24, 2018
View changes

docker/tests/Templates/fxdependent-centos7/Dockerfile

# Install dotnet-runtime
RUN rpm -Uvh https://packages.microsoft.com/config/rhel/7/packages-microsoft-prod.rpm
RUN yum install -y \

This comment has been minimized.

Sign in to view
Copy link
@adityapatwardhan

adityapatwardhan Sep 24, 2018

Member

This wont be needed if using the 2.1-sdk or 2.1-runtime image is used.

This comment has been minimized.

Sign in to view
Copy link
@anmenaga

anmenaga Sep 26, 2018

Author Contributor

Updated base image for ubuntu18.04 and debian.9;
Unfortunately .NET doesn't have any other images.
docker/tests/Templates/fxdependent-debian.8/Dockerfile
git \
wget

# Install dotnet-runtime

This comment has been minimized.

Sign in to view
Copy link
@adityapatwardhan

adityapatwardhan Sep 24, 2018

Member

This might not be needed.

This comment has been minimized.

Sign in to view
Copy link
@anmenaga

anmenaga Sep 26, 2018

Author Contributor

I didn't find .NET image for debian.8
Andrew Menagarishvili
Adressed feedback
Loading status checks…
e832d4d
@anmenaga

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 28, 2018

@TravisEz13 @adityapatwardhan please take a look again.
@adityapatwardhan

adityapatwardhan approved these changes Sep 28, 2018
View changes

@adityapatwardhan

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 28, 2018

@TravisEz13 Please have another look.
@adityapatwardhan

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 28, 2018

@anmenaga Can you have a look at the CodeFactor issues?
@TravisEz13

TravisEz13 approved these changes Oct 1, 2018
View changes

@adityapatwardhan

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 18, 2018

@TravisEz13 @anmenaga There are issues reported by CodeFactor for Docker files. Should they be resolved?
@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 18, 2018

As far as I can tell, All the docker issues from CodeFactor are false positives.

@adityapatwardhan adityapatwardhan merged commit d098e6f into PowerShell:master Oct 18, 2018
7 of 8 checks passed

7 of 8 checks passed

CodeFactor 17 issues found.
Details
PowerShell-CI-linux #2691 succeeded
Details
PowerShell-CI-macos #2690 succeeded
Details
PowerShell-CI-spelling #PR-7830-20180926.01 succeeded
Details
PowerShell-CI-windows #2685 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@anmenaga anmenaga deleted the anmenaga:fxdependentPackageTests branch Oct 31, 2018

adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019

@anmenaga @adityapatwardhan
Adding fxdependent PS package tests (PowerShell#7830)
af78bcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.