Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a paragraph on files.wxs updating #7695
+17
−3
Conversation
iSazonov
assigned
TravisEz13
Sep 3, 2018
iSazonov
requested review from
TravisEz13 and
SteveL-MSFT
Sep 3, 2018
iSazonov
requested a review
from
joeyaiello
as a
code owner
Sep 3, 2018
iSazonov
referenced this pull request
Sep 3, 2018
Merged
Add tests to report when package references are out of date #7661
TravisEz13
reviewed
Sep 4, 2018
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. | ||
| ``` |
This comment has been minimized.
This comment has been minimized.
TravisEz13
Sep 4, 2018
Member
Can you add that there should be an empty line following the copyright header?
This comment has been minimized.
This comment has been minimized.
TravisEz13
approved these changes
Sep 4, 2018
TravisEz13
merged commit 741defe
into
PowerShell:master
Sep 4, 2018
8 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-7695-20180903.01 succeeded with issues
Details
PowerShell-CI-macos
#PR-7695-20180903.01 succeeded
Details
PowerShell-CI-windows
#PR-7695-20180903.01 succeeded
Details
WIP
ready for review
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
license/cla
All CLA requirements met.
Details
iSazonov
deleted the
iSazonov:update-contribution-md
branch
Sep 5, 2018
TravisEz13
added a commit
that referenced
this pull request
Sep 5, 2018
TravisEz13
added this to the v6.1.0 milestone
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
iSazonov commentedSep 3, 2018
•
edited
PR Summary
Add a paragraph in our CONTRIBUTING.md on files.wxs updating.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests